Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 145813010: Files.app: add test for multi-profile desktop movement menu. (Closed)

Created:
6 years, 10 months ago by kinaba
Modified:
6 years, 10 months ago
Reviewers:
hirono
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Files.app: add test for multi-profile desktop movement menu. BUG=341224 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251031

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Rebase + review fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -1 line) Patch
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 6 chunks +30 lines, -1 line 0 comments Download
M chrome/browser/resources/file_manager/background/js/test_util.js View 1 1 chunk +46 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js View 1 chunk +72 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
kinaba
6 years, 10 months ago (2014-02-12 07:35:48 UTC) #1
hirono
Sorry for late replying. lgtm with a nit. https://codereview.chromium.org/145813010/diff/30001/chrome/browser/resources/file_manager/background/js/test_util.js File chrome/browser/resources/file_manager/background/js/test_util.js (right): https://codereview.chromium.org/145813010/diff/30001/chrome/browser/resources/file_manager/background/js/test_util.js#newcode820 chrome/browser/resources/file_manager/background/js/test_util.js:820: * ...
6 years, 10 months ago (2014-02-13 04:53:23 UTC) #2
kinaba
https://codereview.chromium.org/145813010/diff/30001/chrome/browser/resources/file_manager/background/js/test_util.js File chrome/browser/resources/file_manager/background/js/test_util.js (right): https://codereview.chromium.org/145813010/diff/30001/chrome/browser/resources/file_manager/background/js/test_util.js#newcode820 chrome/browser/resources/file_manager/background/js/test_util.js:820: * Waits for the "move to profileId" menu appears ...
6 years, 10 months ago (2014-02-13 05:34:33 UTC) #3
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 10 months ago (2014-02-13 05:34:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/145813010/130001
6 years, 10 months ago (2014-02-13 05:36:47 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 07:40:25 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) check_deps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=229115
6 years, 10 months ago (2014-02-13 07:40:26 UTC) #7
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 10 months ago (2014-02-13 07:43:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/145813010/130001
6 years, 10 months ago (2014-02-13 07:44:18 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 15:47:35 UTC) #10
Message was sent while issue was closed. 
Change committed as 251031

Powered by Google App Engine
This is Rietveld 408576698