PerformanceTests/Parser/query-selector-id-deep.html - Issue 14581013: Optimized querySelector(All) when selector contains #id.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: PerformanceTests/Parser/query-selector-id-deep.html

Issue 14581013: Optimized querySelector(All) when selector contains #id. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <body>	3 <body>

4 <script src="../resources/runner.js"></script>	4 <script src="../resources/runner.js"></script>

5 <script>	5 <script>

6 var parentDiv = document.body;	6 var parentDiv = document.body;

7 for (var i = 0; i < 1000; i++) {	7 for (var i = 0; i < 1000; i++) {

8 var div = document.createElement("div");	8 var div = document.createElement("div");

9 div.id = "foo" + i;	9 div.id = "foo" + i;

10 div.className = "bar" + i;	10 div.className = "bar" + i;

11 parentDiv.appendChild(div);	11 parentDiv.appendChild(div);

12 parentDiv = div;	12 parentDiv = div;

13 }	13 }

14	14

15 var h1 = document.createElement("h1");	15 var h1 = document.createElement("h1");

16 h1.id = "id";	16 h1.id = "id";

17 h1.className = "class";	17 h1.className = "class";

18 parentDiv.appendChild(h1);	18 parentDiv.appendChild(h1);

19	19

20 PerfTestRunner.measureRunsPerSecond({	20 PerfTestRunner.measureRunsPerSecond({

21 description: "This benchmark tests querySelector() for an element that appea rs in the depths in the document",	21 description: "This benchmark tests querySelector() for an element that appea rs in the depths in the document, and is a descendant of an element with a given id",

22 run: function() {	22 run: function() {

23 for (var i = 0; i < 100; i++) {	23 for (var i = 0; i < 100; i++) {

24 document.querySelector("h1");	24 var res = document.querySelector("#foo998 h1");
	haraken 2013/05/14 00:32:58 Instead of modifying existing perf tests, I'd pref Instead of modifying existing perf tests, I'd prefer adding a new perf test for this change.
25 document.querySelector("#id");

26 document.querySelector(".class");

27 }	25 }

28 }});	26 }});

29 </script>	27 </script>

30 </body>	28 </body>

31 </html>	29 </html>

OLD	NEW

« no previous file with comments | « no previous file | PerformanceTests/Parser/query-selector-id-last.html » ('j') | PerformanceTests/Parser/query-selector-id-last.html » ('J')