Implement TypedArray.set function.

src/typedarray.js

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 127 matching lines @@
       endInt = beginInt;
     }
     var newLength = endInt - beginInt;
     var beginByteOffset =
         %TypedArrayGetByteOffset(this) + beginInt * elementSize;
     return new constructor(%TypedArrayGetBuffer(this),
                            beginByteOffset, newLength);
   }
 }
 
+function TypedArraySet(obj, offset) {
+  var intOffset = IS_UNDEFINED(offset) ? 0 : TO_POSITIVE_INTEGER(offset);
+  if (%TypedArraySetSpecialCases(this, obj, intOffset))
+    return;
+
+  var l = obj.length;
+  if (IS_UNDEFINED(l)) {
+    throw MakeTypeError("invalid_argument");
+  }
+  if (intOffset + l > this.length) {
+    throw MakeRangeError("typed_array_set_source_too_long");
+  }
+  for (var i = 0; i < l; i++) {

[rossberg, 2013/05/07 13:53:23]

Is this function supposed to work with non-typed-array receivers? If so,
wouldn't you need to check for overlap as well? If not, don't you need a type
check here?

[Dmitry Lomov (no reviews), 2013/05/07 14:20:00]

Done. No non-typed-array receivers
On 2013/05/07 13:53:23, rossberg wrote:

+    this[intOffset+i] = obj[i];

[rossberg, 2013/05/07 13:53:23]

Style nit: space around +

[Dmitry Lomov (no reviews), 2013/05/07 14:20:00]

Done.

+  }
+}
 
 // -------------------------------------------------------------------
 
 function SetupTypedArray(arrayId, name, constructor, elementSize) {
   %CheckIsBootstrapping();
   var fun = CreateTypedArrayConstructor(name, elementSize,
                                         arrayId, constructor);
   %SetCode(constructor, fun);
   %FunctionSetPrototype(constructor, new $Object());
 
   %SetProperty(constructor.prototype,
                "constructor", constructor, DONT_ENUM);
   %SetProperty(constructor.prototype,
                "BYTES_PER_ELEMENT", elementSize,
                READ_ONLY | DONT_ENUM | DONT_DELETE);
   InstallGetter(constructor.prototype, "buffer", TypedArrayGetBuffer);
   InstallGetter(constructor.prototype, "byteOffset", TypedArrayGetByteOffset);
   InstallGetter(constructor.prototype, "byteLength", TypedArrayGetByteLength);
   InstallGetter(constructor.prototype, "length", TypedArrayGetLength);
 
   InstallFunctions(constructor.prototype, DONT_ENUM, $Array(
-        "subarray", CreateSubArray(elementSize, constructor)
+        "subarray", CreateSubArray(elementSize, constructor),
+        "set", TypedArraySet
   ));
 }
 
 // arrayIds below should be synchronized with Runtime_TypedArrayInitialize.
 SetupTypedArray(1, "Uint8Array", global.Uint8Array, 1);
 SetupTypedArray(2, "Int8Array", global.Int8Array, 1);
 SetupTypedArray(3, "Uint16Array", global.Uint16Array, 2);
 SetupTypedArray(4, "Int16Array", global.Int16Array, 2);
 SetupTypedArray(5, "Uint32Array", global.Uint32Array, 4);
 SetupTypedArray(6, "Int32Array", global.Int32Array, 4);
 SetupTypedArray(7, "Float32Array", global.Float32Array, 4);
 SetupTypedArray(8, "Float64Array", global.Float64Array, 8);
 SetupTypedArray(9, "Uint8ClampedArray", global.Uint8ClampedArray, 1);