Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1458093002: Remove unused ScopedVector from net_log_util (Closed)

Created:
5 years, 1 month ago by Olli Raula
Modified:
5 years, 1 month ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused ScopedVector from net_log_util BUG=554289 Committed: https://crrev.com/02ca4c746567cfef909cd53b09f2cba5b4a05f39 Cr-Commit-Position: refs/heads/master@{#360788}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M net/log/net_log_util.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Olli Raula
Could you review?
5 years, 1 month ago (2015-11-19 13:58:32 UTC) #3
mmenke
On 2015/11/19 13:58:32, Olli Raula wrote: > Could you review? Thanks for doing this, LGTM!
5 years, 1 month ago (2015-11-19 16:21:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458093002/1
5 years, 1 month ago (2015-11-19 16:42:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458093002/1
5 years, 1 month ago (2015-11-20 09:18:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 09:23:07 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 09:24:00 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/02ca4c746567cfef909cd53b09f2cba5b4a05f39
Cr-Commit-Position: refs/heads/master@{#360788}

Powered by Google App Engine
This is Rietveld 408576698