Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Unified Diff: third_party/WebKit/Source/core/svg/SVGImageElement.h

Issue 1458083002: Support fragment URLs for more kinds of SVG images (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Simplifications and an added content test Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGImageElement.h
diff --git a/third_party/WebKit/Source/core/svg/SVGImageElement.h b/third_party/WebKit/Source/core/svg/SVGImageElement.h
index 8373158ac7548968950b9bc3ae058cfc094fb9a4..cdc42828c2a15322eb81f34baa447601c2f2e44e 100644
--- a/third_party/WebKit/Source/core/svg/SVGImageElement.h
+++ b/third_party/WebKit/Source/core/svg/SVGImageElement.h
@@ -51,6 +51,8 @@ public:
// Exposed for testing.
ImageResource* cachedImage() const { return imageLoader().image(); }
+ const AtomicString imageSourceURL() const override;
fs 2015/11/19 14:59:44 Nit: What needs this to be public? (Isn't it acces
davve 2015/11/20 08:14:21 You're very much correct. Left-over from patch set
+
private:
explicit SVGImageElement(Document&);
@@ -67,8 +69,6 @@ private:
LayoutObject* createLayoutObject(const ComputedStyle&) override;
- const AtomicString imageSourceURL() const override;
-
bool haveLoadedRequiredResources() override;
bool selfHasRelativeLengths() const override;

Powered by Google App Engine
This is Rietveld 408576698