Support fragment URLs for more kinds of SVG images

Support fragment URLs for more kinds of SVG images

This patch adds support for SVG fragment URLs in CSS backgrounds,
video poster images, image inputs, content property and svg:image
scenarios. It does so by storing fragment URLs for each
SVGImageForContainer and propgates this URL to SVGImage when drawing.

BUG=128055
Committed: https://crrev.com/87f33f90d6e5714616235de7c4545355f6f3ecc3
Cr-Commit-Position: refs/heads/master@{#360787}

[davve, 2015-11-19 11:07:37]

The CQ bit was checked by davve@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-19 11:07:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1458083002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1458083002/1

[commit-bot: I haz the power, 2015-11-19 12:40:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-19 12:40:34]

Dry run: This issue passed the CQ dry run.

[davve, 2015-11-19 14:14:32]

Description was changed from

==========
[WIP] SVG Fragments

BUG=
==========

to

==========
Support fragment URLs for more kinds of SVG images

This patch adds support for SVG fragment URLs in CSS backgrounds,
video poster images, image inputs, content property and svg:image
scenarios. It does so by storing fragment URLs for each
SVGImageForContainer and propgates this URL to SVGImage when drawing.

BUG=128055
==========

[davve, 2015-11-19 14:14:39]

The CQ bit was checked by davve@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-19 14:14:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1458083002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1458083002/20001

[davve, 2015-11-19 14:15:00]

davve@opera.com changed reviewers:
+ fmalita@chromium.org, fs@opera.com

[davve, 2015-11-19 14:15:00]

PTAL

[fs, 2015-11-19 14:59:44]

LGTM w/ nits

https://codereview.chromium.org/1458083002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/gradients/unprefixed-list-item-gradient.html
(right):

https://codereview.chromium.org/1458083002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/gradients/unprefixed-list-item-gradient.html:19:
</script>
Nit: Not sure what happened here - no NL at EOF?

https://codereview.chromium.org/1458083002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutImageResource.cpp (right):

https://codereview.chromium.org/1458083002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutImageResource.cpp:111: const
AtomicString& urlString = toElement(node)->imageSourceURL();
Nit: With this change I guess the include of HTMLImageElement.h is no longer
needed (but maybe Element.h)

https://codereview.chromium.org/1458083002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/svg/SVGImageElement.h (right):

https://codereview.chromium.org/1458083002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGImageElement.h:54: const AtomicString
imageSourceURL() const override;
Nit: What needs this to be public? (Isn't it accessed through Element only?)

[commit-bot: I haz the power, 2015-11-19 15:48:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-19 15:48:10]

Dry run: This issue passed the CQ dry run.

[davve, 2015-11-20 07:55:23]

The CQ bit was checked by davve@opera.com

[davve, 2015-11-20 07:55:23]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/1458083002/#ps40001
(title: "Simplification wasn't simple enough")

[commit-bot: I haz the power, 2015-11-20 07:55:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1458083002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1458083002/40001

[davve, 2015-11-20 08:14:21]

https://codereview.chromium.org/1458083002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/gradients/unprefixed-list-item-gradient.html
(right):

https://codereview.chromium.org/1458083002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/gradients/unprefixed-list-item-gradient.html:19:
</script>
On 2015/11/19 14:59:44, fs wrote:
> Nit: Not sure what happened here - no NL at EOF?

Yes, I happened to wander into this file and my editor noticed it had no NL at
EOF. I might as well leave it as it was.

https://codereview.chromium.org/1458083002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutImageResource.cpp (right):

https://codereview.chromium.org/1458083002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutImageResource.cpp:111: const
AtomicString& urlString = toElement(node)->imageSourceURL();
On 2015/11/19 14:59:44, fs wrote:
> Nit: With this change I guess the include of HTMLImageElement.h is no longer
> needed (but maybe Element.h)

Thanks.

https://codereview.chromium.org/1458083002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/svg/SVGImageElement.h (right):

https://codereview.chromium.org/1458083002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGImageElement.h:54: const AtomicString
imageSourceURL() const override;
On 2015/11/19 14:59:44, fs wrote:
> Nit: What needs this to be public? (Isn't it accessed through Element only?)

You're very much correct. Left-over from patch set #1.

[commit-bot: I haz the power, 2015-11-20 09:09:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-20 09:10:08]

Patchset 3 (id:??) landed as
https://crrev.com/87f33f90d6e5714616235de7c4545355f6f3ecc3
Cr-Commit-Position: refs/heads/master@{#360787}