Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Issue 1458073002: Import url_scheme_util.h instead of including it (Closed)

Created:
5 years, 1 month ago by vabr (Chromium)
Modified:
5 years, 1 month ago
CC:
bondd+autofillwatch_chromium.org, browser-components-watch_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, estade+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, rouslan+autofill_chromium.org, sdefresne+watch_chromium.org, vabr+watchlistautofill_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Import url_scheme_util.h instead of including it This has been pointed out in https://goo.gl/CRH4Dz. This CL unifies the imorts/includes for url_scheme_util.h in particular, to keep the result of the other CL consistent. There are likely more files like that in the code-base, but switching them all would require scripting. The benefits are not clearly supporting such effort. R=eugenebut@chromium.org BUG=514241 Committed: https://crrev.com/85f7701ff7313cb529fc4a3dcf3b61820837ec32 Cr-Commit-Position: refs/heads/master@{#360600}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M components/translate/ios/browser/language_detection_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/autofill/form_input_accessory_view_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/autofill/form_suggestion_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/net/web_http_protocol_handler_delegate.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/ui/crw_ui_web_view_web_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
vabr (Chromium)
Hi Eugene, PTAL. Cheers, Vaclav
5 years, 1 month ago (2015-11-19 11:05:37 UTC) #1
Eugene But (OOO till 7-30)
Thanks for cleanup. Please update CL description to fit 80 symbols where possible (or better ...
5 years, 1 month ago (2015-11-19 15:00:31 UTC) #2
vabr (Chromium)
Thanks, Eugene! Description edited as requested. @sdefresne -- could you please rubber-stamp //ios/chrome and //components? ...
5 years, 1 month ago (2015-11-19 16:03:01 UTC) #5
sdefresne
rubbertstamp lgtm
5 years, 1 month ago (2015-11-19 16:20:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458073002/1
5 years, 1 month ago (2015-11-19 16:22:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 16:29:35 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 16:30:49 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/85f7701ff7313cb529fc4a3dcf3b61820837ec32
Cr-Commit-Position: refs/heads/master@{#360600}

Powered by Google App Engine
This is Rietveld 408576698