Added --force-ui-direction flag for developers to force LTR or RTL.

Added --force-ui-direction flag for developers to force LTR or RTL.

Setting this flag to ltr or rtl will force the system-wide text
direction to the chosen direction. This allows developers to test RTL
layouts without having to actually switch their language to Hebrew or
Arabic.

BUG=558208
Committed: https://crrev.com/49ae7c7da53213681a835f53380f275af4c0a4e4
Cr-Commit-Position: refs/heads/master@{#363135}

[Matt Giuca, 2015-11-26 06:36:40]

mgiuca@chromium.org changed reviewers:
+ jshin@chromium.org, rkaplow@chromium.org

[Matt Giuca, 2015-11-26 06:36:41]

jshin: Please review changes in base/i18n.

mark: Please review changes in BUILD.gn and base.gypi.

rkaplow: Please review changes in histograms.xml.

Feel free to add anybody you think may have an opinion about whether this is
necessary. I think it would be very helpful for detecting and debugging RTL
issues in general.

[Matt Giuca, 2015-11-26 06:37:10]

mgiuca@chromium.org changed reviewers:
+ mark@chromium.org

[Matt Giuca, 2015-11-26 06:37:11]

+mark (try again)

[Mark Mentovai, 2015-11-26 13:26:48]

LGTM

[rkaplow, 2015-11-27 16:35:38]

lgtm

[Matt Giuca, 2015-11-30 06:05:31]

Thanks. So I don't *technically* need jshin (mark is a higher level OWNERS), but
I will wait awhile because jshin is probably more familiar with the immediate
code.

[Matt Giuca, 2015-12-02 02:17:52]

On 2015/11/30 06:05:31, Matt Giuca wrote:
> Thanks. So I don't *technically* need jshin (mark is a higher level OWNERS),
but
> I will wait awhile because jshin is probably more familiar with the immediate
> code.

Jungshik, PTAL?

[jungshik at Google, 2015-12-02 23:29:51]

LGTM and thanks for adding this (and sorry for the late reply).

[Matt Giuca, 2015-12-02 23:31:50]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2015-12-02 23:34:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1458043003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1458043003/20001

[commit-bot: I haz the power, 2015-12-02 23:40:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-02 23:40:29]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Matt Giuca, 2015-12-03 06:24:55]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2015-12-03 06:24:56]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org,
rkaplow@chromium.org, jshin@chromium.org
Link to the patchset: https://codereview.chromium.org/1458043003/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2015-12-03 06:25:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1458043003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1458043003/40001

[commit-bot: I haz the power, 2015-12-03 08:21:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-03 08:21:37]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[Matt Giuca, 2015-12-04 00:50:59]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2015-12-04 00:53:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1458043003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1458043003/40001

[commit-bot: I haz the power, 2015-12-04 01:10:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 01:10:11]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[Matt Giuca, 2015-12-04 02:41:19]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2015-12-04 02:41:20]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org,
rkaplow@chromium.org, jshin@chromium.org
Link to the patchset: https://codereview.chromium.org/1458043003/#ps60001
(title: "Rebase.")

[commit-bot: I haz the power, 2015-12-04 02:43:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1458043003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1458043003/60001

[commit-bot: I haz the power, 2015-12-04 04:36:56]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-04 04:37:57]

Description was changed from

==========
Added --force-ui-direction flag for developers to force LTR or RTL.

Setting this flag to ltr or rtl will force the system-wide text
direction to the chosen direction. This allows developers to test RTL
layouts without having to actually switch their language to Hebrew or
Arabic.

BUG=558208
==========

to

==========
Added --force-ui-direction flag for developers to force LTR or RTL.

Setting this flag to ltr or rtl will force the system-wide text
direction to the chosen direction. This allows developers to test RTL
layouts without having to actually switch their language to Hebrew or
Arabic.

BUG=558208

Committed: https://crrev.com/49ae7c7da53213681a835f53380f275af4c0a4e4
Cr-Commit-Position: refs/heads/master@{#363135}
==========

[commit-bot: I haz the power, 2015-12-04 04:37:58]

Patchset 4 (id:??) landed as
https://crrev.com/49ae7c7da53213681a835f53380f275af4c0a4e4
Cr-Commit-Position: refs/heads/master@{#363135}