Issue 145803002: Disable SetAllocationTimeout in fuzz-natives test since it has varargs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 145803002: Disable SetAllocationTimeout in fuzz-natives test since it has varargs. (Closed)

Created:
6 years, 11 months ago by Michael Achenbach

Modified:
6 years, 11 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Disable SetAllocationTimeout in fuzz-natives test since it has varargs. BUG= R=mstarzinger@chromium.org TBR=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18791

Patch Set 2 : Review #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
M	test/mjsunit/fuzz-natives-part1.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	test/mjsunit/fuzz-natives-part2.js	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/mjsunit/fuzz-natives-part3.js	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/mjsunit/fuzz-natives-part4.js	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (if comment is addressed). https://codereview.chromium.org/145803002/diff/1/test/mjsunit/fuzz-natives-part1.js File test/mjsunit/fuzz-natives-part1.js (right): https://codereview.chromium.org/145803002/diff/1/test/mjsunit/fuzz-natives-part1.js#newcode174 test/mjsunit/fuzz-natives-part1.js:174: "SetAllocationTimeout": true, Please keep ...

6 years, 11 months ago (2014-01-23 16:30:03 UTC) #2

Michael Achenbach

On 2014/01/23 16:30:03, Michael Starzinger wrote: > LGTM (if comment is addressed). > > https://codereview.chromium.org/145803002/diff/1/test/mjsunit/fuzz-natives-part1.js ...

6 years, 11 months ago (2014-01-23 16:32:05 UTC) #3

Michael Achenbach

6 years, 11 months ago (2014-01-23 16:33:43 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r18791 (presubmit successful).

Expand Messages | Collapse Messages

Issue 145803002: Disable SetAllocationTimeout in fuzz-natives test since it has varargs. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Review #

Messages