Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1458003005: Provide an RNG seed for creating snapshot. (Closed)

Created:
5 years, 1 month ago by Yang
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Provide an RNG seed for creating snapshot. If Math.random is called when creating the snapshot, we need seeds to work with. Those seeds are going to be overwritten after deserializing from the snapshot. NOTRY=true NOTREECHECKS=true TBR=bmeurer@chromium.org Committed: https://crrev.com/b154e8d7a08e19defc50a35587777f129449c512 Cr-Commit-Position: refs/heads/master@{#32134}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/js/math.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Yang
5 years, 1 month ago (2015-11-20 08:47:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458003005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458003005/1
5 years, 1 month ago (2015-11-20 08:47:31 UTC) #3
Benedikt Meurer
LGTM
5 years, 1 month ago (2015-11-20 08:47:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458003005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458003005/1
5 years, 1 month ago (2015-11-20 08:49:00 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 08:49:08 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 08:49:32 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b154e8d7a08e19defc50a35587777f129449c512
Cr-Commit-Position: refs/heads/master@{#32134}

Powered by Google App Engine
This is Rietveld 408576698