Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 14580012: Update mjsunit tests to be complaint with ES6 implementation of typed arrays (Closed)

Created:
7 years, 7 months ago by Dmitry Lomov (no reviews)
Modified:
7 years, 7 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Update mjsunit tests to be complaian with ES6 implementation of typed arrays R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14575

Patch Set 1 : #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -46 lines) Patch
M test/mjsunit/external-array.js View 6 chunks +1 line, -24 lines 0 comments Download
M test/mjsunit/external-array-no-sse2.js View 5 chunks +1 line, -22 lines 6 comments Download

Messages

Total messages: 3 (0 generated)
Dmitry Lomov (no reviews)
I have removed all non-ES6-complaint tests from our mjsunit tests. This is structured so that ...
7 years, 7 months ago (2013-05-07 13:21:29 UTC) #1
rossberg
LGTM with nit https://codereview.chromium.org/14580012/diff/4001/test/mjsunit/external-array-no-sse2.js File test/mjsunit/external-array-no-sse2.js (left): https://codereview.chromium.org/14580012/diff/4001/test/mjsunit/external-array-no-sse2.js#oldcode168 test/mjsunit/external-array-no-sse2.js:168: a.BYTES_PER_ELEMENT = 42; Did you want ...
7 years, 7 months ago (2013-05-07 13:58:05 UTC) #2
Dmitry Lomov (no reviews)
7 years, 7 months ago (2013-05-07 14:03:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14575 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698