Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1457963002: Use scoped_ptr instead of linked_ptr from /content/renderer (Closed)

Created:
5 years, 1 month ago by limasdf
Modified:
5 years, 1 month ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, posciak+watch_chromium.org, nasko+codewatch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use scoped_ptr instead of linked_ptr from /content/renderer R=avi@chromium.org BUG=556939 Committed: https://crrev.com/81d962ea0c83e6512f0364ceb3b29fff91bf739a Cr-Commit-Position: refs/heads/master@{#360779}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix android compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -47 lines) Patch
M content/renderer/media/video_capture_impl_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/npapi/webplugin_delegate_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/pepper/event_conversion.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/event_conversion.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M content/renderer/pepper/host_var_tracker.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 2 chunks +5 lines, -9 lines 0 comments Download
M content/renderer/pepper/video_decoder_shim.h View 2 chunks +1 line, -2 lines 0 comments Download
M content/renderer/pepper/video_decoder_shim.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/presentation/presentation_dispatcher.h View 2 chunks +1 line, -2 lines 0 comments Download
M content/renderer/presentation/presentation_dispatcher.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/render_view_impl.h View 3 chunks +3 lines, -4 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 3 chunks +8 lines, -11 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
limasdf
PTAL! it's almost mechanical change. https://codereview.chromium.org/1457963002/diff/1/content/renderer/pepper/event_conversion.cc File content/renderer/pepper/event_conversion.cc (right): https://codereview.chromium.org/1457963002/diff/1/content/renderer/pepper/event_conversion.cc#newcode727 content/renderer/pepper/event_conversion.cc:727: return events; sad. a ...
5 years, 1 month ago (2015-11-19 05:51:21 UTC) #3
Avi (use Gerrit)
lgtm https://codereview.chromium.org/1457963002/diff/1/content/renderer/pepper/event_conversion.cc File content/renderer/pepper/event_conversion.cc (right): https://codereview.chromium.org/1457963002/diff/1/content/renderer/pepper/event_conversion.cc#newcode727 content/renderer/pepper/event_conversion.cc:727: return events; On 2015/11/19 05:51:20, limasdf wrote: > ...
5 years, 1 month ago (2015-11-19 23:12:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457963002/1
5 years, 1 month ago (2015-11-19 23:16:15 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, no build URL) android_chromium_gn_compile_rel on ...
5 years, 1 month ago (2015-11-19 23:34:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457963002/1
5 years, 1 month ago (2015-11-20 00:14:50 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, no build URL) android_chromium_gn_compile_dbg on ...
5 years, 1 month ago (2015-11-20 00:33:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457963002/1
5 years, 1 month ago (2015-11-20 01:39:28 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/147269) android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 1 month ago (2015-11-20 01:56:26 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457963002/20001
5 years, 1 month ago (2015-11-20 05:32:59 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-20 08:39:27 UTC) #20
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 08:40:41 UTC) #21
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/81d962ea0c83e6512f0364ceb3b29fff91bf739a
Cr-Commit-Position: refs/heads/master@{#360779}

Powered by Google App Engine
This is Rietveld 408576698