Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 1457903002: Roll src/third_party/libsrtp/ 502e81a23..b8dd754b4 (2 commits). (Closed)

Created:
5 years, 1 month ago by joachim
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll src/third_party/libsrtp/ 502e81a23..b8dd754b4 (2 commits). https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/502e81a238a8..b8dd754b4fa0 $ git log 502e81a23..b8dd754b4 --date=short --no-merges --format='%ad %ae %s' 2015-11-18 jiayl Update libsrtp to upstream commit be95365fbb4788b688cab7af61c65b7989055fb4 2015-08-25 jiayl Set "use_openssl" gyp variable to 1 if it is undefined This CL updates libsrtp 1.5.x to the latest upstream commit in the "1_5_x_throttle" branch. Notable changes: - Increase maximum tag length to 16 bytes to allow for GCM cipher suite. - Prevent potential DoS attack due to lack of bounds checking on RTP header CSRC count and extension header length. Credit goes to Randell Jesup and the Firefox team for reporting this issue. Committed: https://crrev.com/1b64adc3724092af5a37f3eb169de1e783ccf47d Cr-Commit-Position: refs/heads/master@{#360613}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
joachim
Ptal
5 years, 1 month ago (2015-11-18 23:26:36 UTC) #2
tommi (sloooow) - chröme
Patrik - can you take a look?
5 years, 1 month ago (2015-11-19 14:20:54 UTC) #4
phoglund_chromium
I did take a look at the libsrtp code and I think the changes look ...
5 years, 1 month ago (2015-11-19 14:55:07 UTC) #6
tommi (sloooow) - chröme
lgtm
5 years, 1 month ago (2015-11-19 15:05:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457903002/1
5 years, 1 month ago (2015-11-19 15:06:12 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/98319)
5 years, 1 month ago (2015-11-19 15:25:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457903002/1
5 years, 1 month ago (2015-11-19 16:11:30 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 17:24:19 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 17:25:20 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b64adc3724092af5a37f3eb169de1e783ccf47d
Cr-Commit-Position: refs/heads/master@{#360613}

Powered by Google App Engine
This is Rietveld 408576698