Start app shim when app launched.

chrome/browser/web_applications/web_app_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/web_applications/web_app_mac.h"
 
 #import <Cocoa/Cocoa.h>
 
+#include "base/callback.h"
+#include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/mac/bundle_locations.h"
 #include "base/mac/foundation_util.h"
+#include "base/mac/launch_services_util.h"
 #include "base/mac/mac_logging.h"
 #include "base/mac/mac_util.h"
 #include "base/mac/scoped_cftyperef.h"
 #include "base/memory/scoped_nsobject.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/utf_string_conversions.h"
+#include "chrome/common/chrome_switches.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/web_applications/web_app_ui.h"
 #include "chrome/browser/web_applications/web_app.h"
 #include "chrome/common/chrome_paths_internal.h"
 #include "chrome/common/mac/app_mode_common.h"
 #include "content/public/browser/browser_thread.h"
 #include "grit/chromium_strings.h"
 #include "skia/ext/skia_utils_mac.h"
 #include "third_party/icon_family/IconFamily.h"
 #include "ui/base/l10n/l10n_util_mac.h"
 #include "ui/gfx/image/image_family.h"
 
@@ skipping 65 matching lines @@
   if (base::mac::GetUserDirectory(NSApplicationDirectory, &path))
     return path;
   return base::FilePath();
 }
 
 }  // namespace
 
 
 namespace web_app {
 
 const char kChromeAppDirName[] = "Chrome Apps.localized";

[jackhou1, 2013/05/17 05:49:33]

Should this be split into:
Chrome Apps
Chromium Apps
Chrome Canary Apps

[benwells, 2013/05/17 05:59:41]

Yes, and it should be coming from the sources files. I think you can do that in
a follow up patch.

 
 WebAppShortcutCreator::WebAppShortcutCreator(
     const base::FilePath& user_data_dir,
     const ShellIntegration::ShortcutInfo& shortcut_info,
     const string16& chrome_bundle_id)
     : user_data_dir_(user_data_dir),
       info_(shortcut_info),
       chrome_bundle_id_(chrome_bundle_id) {
 }
 
@@ skipping 178 matching lines @@
 namespace web_app {
 
 base::FilePath GetAppInstallPath(
     const ShellIntegration::ShortcutInfo& shortcut_info) {
   WebAppShortcutCreator shortcut_creator(base::FilePath(),
                                          shortcut_info,
                                          string16());
   return shortcut_creator.GetShortcutPath();
 }
 
+void LaunchShimOnFileThread(Profile* profile,
+                            const extensions::Extension* extension,
+                            base::Callback<void(bool)> completed) {

[tapted, 2013/05/17 06:44:00]

Is there only one entrypoint now? It looks like |completed| is only ever
`DoNothing`, in which case it should be dropped.

[jackhou1, 2013/05/21 03:13:22]

Done.

+  DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE));
+  base::FilePath shim_path = GetAppInstallPath(
+      web_app::ShortcutInfoForExtensionAndProfile(extension, profile));
+  if (shim_path.empty()) {
+    content::BrowserThread::PostTask(
+        content::BrowserThread::UI, FROM_HERE, base::Bind(completed, false));
+    return;
+  }
+  CommandLine command_line(CommandLine::NO_PROGRAM);
+  command_line.AppendSwitch(app_mode::kNoLaunchApp);
+  base::mac::OpenApplicationWithPath(shim_path, command_line, NULL);
+  content::BrowserThread::PostTask(
+      content::BrowserThread::UI, FROM_HERE, base::Bind(completed, true));
+}
+
+void LaunchShim(Profile* profile,

[tapted, 2013/05/17 06:44:00]

I think this should first check with the shim manager to ensure there isn't
already a shim running.

[jackhou1, 2013/05/21 03:13:22]

ATM the shim manager doesn't keep track of shims after starting them. After the
refactor (15269003) we can probably do this in the extension app shim handler.
Alternatively, we can just make AppShimHostManager track app shims.

+                const extensions::Extension* extension,
+                base::Callback<void(bool)> completed) {
+  content::BrowserThread::PostTask(
+      content::BrowserThread::FILE, FROM_HERE,
+      base::Bind(&LaunchShimOnFileThread, profile, extension, completed));
+}
+
 namespace internals {
 
 base::FilePath GetAppBundleByExtensionId(std::string extension_id) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE));
   // This matches APP_MODE_APP_BUNDLE_ID in chrome/chrome.gyp.
   std::string bundle_id =
       base::mac::BaseBundleID() + std::string(".app.") + extension_id;
   base::mac::ScopedCFTypeRef<CFStringRef> bundle_id_cf(
       base::SysUTF8ToCFStringRef(bundle_id));
   CFURLRef url_ref = NULL;
@@ skipping 31 matching lines @@
 void UpdatePlatformShortcuts(
     const base::FilePath& web_app_path,
     const ShellIntegration::ShortcutInfo& shortcut_info) {
   // TODO(benwells): Implement this when shortcuts / weblings are enabled on
   // mac.
 }
 
 }  // namespace internals
 
 }  // namespace web_app