Start app shim when app launched.

chrome/app/chrome_main_app_mode_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // On Mac, one can't make shortcuts with command-line arguments. Instead, we
 // produce small app bundles which locate the Chromium framework and load it,
 // passing the appropriate data. This is the entry point into the framework for
 // those app bundles.
 
 #import <Cocoa/Cocoa.h>
@@ skipping 48 matching lines @@
   void OnDidActivateApplication();
 
   // Quits the app shim process.
   void Quit();
 
   IPC::ChannelProxy* channel_;
 
   DISALLOW_COPY_AND_ASSIGN(AppShimController);
 };
 
-AppShimController::AppShimController() : channel_(NULL) {
-}
+AppShimController::AppShimController() : channel_(NULL) {}
 
 void AppShimController::Init() {
   DCHECK(g_io_thread);
   NSString* chrome_bundle_path =
       base::SysUTF8ToNSString(g_info->chrome_outer_bundle_path.value());
   NSBundle* chrome_bundle = [NSBundle bundleWithPath:chrome_bundle_path];
   base::FilePath user_data_dir;
   if (!chrome::GetUserDataDirectoryForBrowserBundle(chrome_bundle,
                                                     &user_data_dir)) {
+    LOG(ERROR) << "Cannot get user data directory for browser bundle.";

[Nico, 2013/05/30 00:14:44]

Logging isn't useful. If this important enough that we want to learn about this,
add a CHECK or DCHECK. If it isn't, do nothing. Logspam doesn't help.

[jackhou1, 2013/05/30 01:43:30]

It's probably not important enough. I've also changed the one in OnChannelError
to a DLOG.

     Quit();
     return;
   }
 
   base::FilePath socket_path =
       user_data_dir.Append(app_mode::kAppShimSocketName);
   IPC::ChannelHandle handle(socket_path.value());
   channel_ = new IPC::ChannelProxy(handle, IPC::Channel::MODE_NAMED_CLIENT,
       this, g_io_thread->message_loop_proxy());
 
   channel_->Send(new AppShimHostMsg_LaunchApp(
-      g_info->profile_dir.value(), g_info->app_mode_id));
+      g_info->profile_dir, g_info->app_mode_id,
+      !CommandLine::ForCurrentProcess()->HasSwitch(app_mode::kNoLaunchApp)));

[Nico, 2013/05/30 00:14:44]

Not clear what the bool does here. Consider using a named bool or a
/*param_name=*/ comment to make that clearer.

[jackhou1, 2013/05/30 01:43:30]

Done.

 }
 
 bool AppShimController::OnMessageReceived(const IPC::Message& message) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(AppShimController, message)
     IPC_MESSAGE_HANDLER(AppShimMsg_LaunchApp_Done, OnLaunchAppDone)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
 
   return handled;
 }
 
 void AppShimController::OnChannelError() {
   LOG(ERROR) << "App shim channel error.";
   Quit();
 }
 
 void AppShimController::OnLaunchAppDone(bool success) {
   if (!success) {
+    LOG(ERROR) << "App launch failed.";

[Nico, 2013/05/30 00:14:44]

see above

[jackhou1, 2013/05/30 01:43:30]

Done.

     Quit();
     return;
   }
+
   [[[NSWorkspace sharedWorkspace] notificationCenter]
       addObserverForName:NSWorkspaceDidActivateApplicationNotification
                   object:nil
                    queue:nil
               usingBlock:^(NSNotification* notification) {
       NSRunningApplication* activated_app =
           [[notification userInfo] objectForKey:NSWorkspaceApplicationKey];
       if ([activated_app isEqual:[NSRunningApplication currentApplication]])
         OnDidActivateApplication();
   }];
@@ skipping 128 matching lines @@
 extern "C" {
 
 // |ChromeAppModeStart()| is the point of entry into the framework from the app
 // mode loader.
 __attribute__((visibility("default")))
 int ChromeAppModeStart(const app_mode::ChromeAppModeInfo* info);
 
 }  // extern "C"
 
 int ChromeAppModeStart(const app_mode::ChromeAppModeInfo* info) {
+  CommandLine::Init(info->argc, info->argv);
+
   base::mac::ScopedNSAutoreleasePool scoped_pool;
   base::AtExitManager exit_manager;
   chrome::RegisterPathProvider();
 
   if (info->major_version < app_mode::kCurrentChromeAppModeInfoMajorVersion) {
     RAW_LOG(ERROR, "App Mode Loader too old.");
     return 1;
   }
   if (info->major_version > app_mode::kCurrentChromeAppModeInfoMajorVersion) {
     RAW_LOG(ERROR, "Browser Framework too old to load App Shortcut.");
@@ skipping 26 matching lines @@
   // fully initialized don't receive a reply until its run loop starts. Once
   // the reply is received, Chrome will have opened its IPC port, guaranteed.
   [ReplyEventHandler pingProcess:psn andCall:base::Bind(&OnPingChromeReply)];
 
   base::MessageLoopForUI main_message_loop;
   main_message_loop.set_thread_name("MainThread");
   base::PlatformThread::SetName("CrAppShimMain");
   main_message_loop.Run();
   return 0;
 }