Start app shim when app launched.

chrome/browser/web_applications/web_app_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/web_applications/web_app_mac.h"
 
 #import <Cocoa/Cocoa.h>
 
+#include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/mac/bundle_locations.h"
 #include "base/mac/foundation_util.h"
+#include "base/mac/launch_services_util.h"
 #include "base/mac/mac_logging.h"
 #include "base/mac/mac_util.h"
 #include "base/mac/scoped_cftyperef.h"
 #include "base/memory/scoped_nsobject.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/utf_string_conversions.h"
+#include "chrome/common/chrome_switches.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/web_applications/web_app_ui.h"
 #include "chrome/browser/web_applications/web_app.h"
 #include "chrome/common/chrome_paths_internal.h"
 #include "chrome/common/mac/app_mode_common.h"
 #include "content/public/browser/browser_thread.h"
 #include "grit/chromium_strings.h"
 #include "skia/ext/skia_utils_mac.h"
 #include "third_party/icon_family/IconFamily.h"
 #include "ui/base/l10n/l10n_util_mac.h"
 #include "ui/gfx/image/image_family.h"
 
@@ skipping 264 matching lines @@
 namespace web_app {
 
 base::FilePath GetAppInstallPath(
     const ShellIntegration::ShortcutInfo& shortcut_info) {
   WebAppShortcutCreator shortcut_creator(base::FilePath(),
                                          shortcut_info,
                                          string16());
   return shortcut_creator.GetShortcutPath();
 }
 
+void LaunchShimOnFileThread(Profile* profile,

[tapted, 2013/05/29 04:20:30]

can you move this to an anonymous namespace?

[jackhou1, 2013/05/29 05:53:04]

Done.

+                            const extensions::Extension* extension) {
+  DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE));
+  base::FilePath shim_path = GetAppInstallPath(
+      web_app::ShortcutInfoForExtensionAndProfile(extension, profile));
+  if (shim_path.empty())
+    return;
+
+  CommandLine command_line(CommandLine::NO_PROGRAM);
+  command_line.AppendSwitch(app_mode::kNoLaunchApp);
+  base::mac::OpenApplicationWithPath(shim_path, command_line, NULL);
+}
+
+void MaybeLaunchShortcut(Profile* profile,
+                         const extensions::Extension* extension) {
+  content::BrowserThread::PostTask(
+      content::BrowserThread::FILE, FROM_HERE,
+      base::Bind(&LaunchShimOnFileThread, profile, extension));

[tapted, 2013/05/29 04:20:30]

I've just realised.. posting Extension pointers to non-UI threads isn't safe. If
the extension is uninstalled in parallel, you can get a crash. (E.g., browser
starts in response to a shim, Chrome sync kicks in, notices you've uninstalled
the app elsewhere, removes the local copy, deletes extension pointer, then tries
to launch via deleted pointer).

(aside: the function ShortcutInfoForExtensionAndProfile should probably have a
DCHECK(..CurrentlyOn(UI))..).

ShortcutInfo is copyable, so I'd bind one of those in the closure, to keep it
generic.

Note the app list will want to pass a ShortcutInfo in to a public API to launch
its shim, since it doesn't have an Extension*. We can make that a new function,
or replace this one, and call web_app::ShortcutInfoForExtensionAndProfile(..) in
ExtensionAppShimHandler::StartShim(..). Not sure which is better.

[jackhou1, 2013/05/29 05:53:04]

Done.

Changed MaybeCreateShortcut since
chrome/browser/ui/web_applications/web_app_ui.h is already in apps/DEPS.

+}
+
 namespace internals {
 
 base::FilePath GetAppBundleByExtensionId(std::string extension_id) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE));
   // This matches APP_MODE_APP_BUNDLE_ID in chrome/chrome.gyp.
   std::string bundle_id =
       base::mac::BaseBundleID() + std::string(".app.") + extension_id;
   base::mac::ScopedCFTypeRef<CFStringRef> bundle_id_cf(
       base::SysUTF8ToCFStringRef(bundle_id));
   CFURLRef url_ref = NULL;
@@ skipping 31 matching lines @@
 void UpdatePlatformShortcuts(
     const base::FilePath& web_app_path,
     const ShellIntegration::ShortcutInfo& shortcut_info) {
   // TODO(benwells): Implement this when shortcuts / weblings are enabled on
   // mac.
 }
 
 }  // namespace internals
 
 }  // namespace web_app