Change horizontal/vertical separators in OSX bubble UI to be less light.

Change horizontal/vertical separators in OSX bubble UI to be less light.

BUG=558839
Committed: https://crrev.com/4cec76769e05663cf055ee387ec63eb34c7fbc25
Cr-Commit-Position: refs/heads/master@{#361167}

[lgarron, 2015-11-20 02:17:16]

lgarron@chromium.org changed reviewers:
+ rsesek@chromium.org, sail@chromium.org

[lgarron, 2015-11-20 02:17:16]

See https://crbug.com/558839

[lgarron, 2015-11-20 02:21:42]

felt@ suggested comparing this against accessibility guidelines. The baseline
rule of thumb of a contrast of 3 would be met by alpha 0.42 (assuming no gamma
shenanigans):

http://leaverou.github.io/contrast-ratio/#rgba%280%2C%200%2C%200%2C%200.42%29...

However, that is still not very visible to me. 0.75 is a lot more clear without
being distracting (see bug screenshot).

[lgarron, 2015-11-20 21:48:24]

Actually, it turns out that the alpha value does not scale RGB the same way as
CSS.

An alpha value of 0.75 gives me rgb(236, 236, 236) on my Mac.
The equivalent line in the profile switcher on Windows is rgb(233, 233, 233).

So, this CL actually brings us close to platform parity.

[felt, 2015-11-21 01:38:18]

On 2015/11/20 21:48:24, lgarron wrote:
> Actually, it turns out that the alpha value does not scale RGB the same way as
> CSS.
> 
> An alpha value of 0.75 gives me rgb(236, 236, 236) on my Mac.
> The equivalent line in the profile switcher on Windows is rgb(233, 233, 233).
> 
> So, this CL actually brings us close to platform parity.

Can you share a screenshot?

[lgarron, 2015-11-21 01:42:50]

On 2015/11/21 at 01:38:18, felt wrote:
> On 2015/11/20 21:48:24, lgarron wrote:
> > Actually, it turns out that the alpha value does not scale RGB the same way
as
> > CSS.
> > 
> > An alpha value of 0.75 gives me rgb(236, 236, 236) on my Mac.
> > The equivalent line in the profile switcher on Windows is rgb(233, 233,
233).
> > 
> > So, this CL actually brings us close to platform parity.
> 
> Can you share a screenshot?

Lots of screenshots in the bug.

[lgarron, 2015-11-21 01:43:17]

Description was changed from

==========
Change horizontal/vertical separators in OSX bubble UI to be less light.

BUG=421248
==========

to

==========
Change horizontal/vertical separators in OSX bubble UI to be less light.

BUG=558839
==========

[lgarron, 2015-11-21 01:43:55]

On 2015/11/21 at 01:42:50, lgarron wrote:
> On 2015/11/21 at 01:38:18, felt wrote:
> > On 2015/11/20 21:48:24, lgarron wrote:
> > > Actually, it turns out that the alpha value does not scale RGB the same
way as
> > > CSS.
> > > 
> > > An alpha value of 0.75 gives me rgb(236, 236, 236) on my Mac.
> > > The equivalent line in the profile switcher on Windows is rgb(233, 233,
233).
> > > 
> > > So, this CL actually brings us close to platform parity.
> > 
> > Can you share a screenshot?
> 
> Lots of screenshots in the bug.

... which was incorrect if you were looking at the CL description. I've
corrected it to https://crbug.com/558839 .

[Robert Sesek, 2015-11-21 03:45:33]

Can you post before and after screen shots?

I'm definitely in favor of making things more visible/legible, but you should be
careful with how you're measuring RGB values. OS X (and Windows) both support
color sync profiles that will provide different results depending on the output
device and system preferences.

[lgarron, 2015-11-21 23:52:09]

On 2015/11/21 at 03:45:33, rsesek wrote:
> Can you post before and after screen shots?
> 
> I'm definitely in favor of making things more visible/legible, but you should
be careful with how you're measuring RGB values. OS X (and Windows) both support
color sync profiles that will provide different results depending on the output
device and system preferences.

See comment #1 in the bug: https://crbug.com/558839

This CL matches the 0.75 screenshot (vs. the first two screenshots with light
lines).

[Robert Sesek, 2015-11-23 16:04:28]

OK LGTM

[lgarron, 2015-11-23 19:20:51]

The CQ bit was checked by lgarron@chromium.org

[commit-bot: I haz the power, 2015-11-23 19:22:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1457883004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1457883004/1

[commit-bot: I haz the power, 2015-11-23 20:18:37]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-23 20:19:27]

Patchset 1 (id:??) landed as
https://crrev.com/4cec76769e05663cf055ee387ec63eb34c7fbc25
Cr-Commit-Position: refs/heads/master@{#361167}