Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1457883003: Correctly parse new regexp flags in v8::RegExp::New. (Closed)

Created:
5 years, 1 month ago by Yang
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Correctly parse new regexp flags in v8::RegExp::New. R=ishell@chromium.org, verwaest@chromium.org Committed: https://crrev.com/eb25b8c54bc00d288822005f0a58ebc71db149cb Cr-Commit-Position: refs/heads/master@{#32106}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M src/api.cc View 1 chunk +3 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Yang
5 years, 1 month ago (2015-11-19 09:45:41 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457883003/1
5 years, 1 month ago (2015-11-19 09:46:15 UTC) #3
Igor Sheludko
lgtm
5 years, 1 month ago (2015-11-19 09:51:08 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-19 10:29:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457883003/1
5 years, 1 month ago (2015-11-19 10:31:44 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 10:32:55 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 10:33:25 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/eb25b8c54bc00d288822005f0a58ebc71db149cb
Cr-Commit-Position: refs/heads/master@{#32106}

Powered by Google App Engine
This is Rietveld 408576698