Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 1457873007: add compiltion unit accessor to completion target (Closed)

Created:
5 years, 1 month ago by danrubel
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M pkg/analysis_server/lib/src/provisional/completion/dart/completion_target.dart View 5 chunks +16 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 1 month ago (2015-11-21 04:00:04 UTC) #2
scheglov
LGTM
5 years, 1 month ago (2015-11-21 04:41:10 UTC) #3
danrubel
5 years ago (2015-11-21 15:07:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
11f93868579fbe0c7939ec708c622c1cd3d33a77 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698