Issue 1457863002: Revert of Fix UB in SkDivBits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1457863002: Revert of Fix UB in SkDivBits (Closed)

Created:
5 years, 1 month ago by mtklein

Modified:
5 years, 1 month ago

Reviewers:
caryclark, mtklein_C

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Fix UB in SkDivBits (patchset #2 id:10002 of https://codereview.chromium.org/1455163004/ ) Reason for revert: Need to reland with #define guards for tiny layout test changes. (Yikes!) Original issue's description: > Fix UB in SkDivBits > > DIVBITS_ITER was shifting bits up into the sign bit, which is a no-no. > This turns numer into a uint32_t to make those defined, and adds a few notes. > > x >= 0 is always true for unsigned x, so we needed a few small logic refactors. > > BUG=skia:3562 > > Committed: https://skia.googlesource.com/skia/+/988adddd48322bfa3e3cb0c017cfce71fbbf1123 TBR=caryclark@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3562 Committed: https://skia.googlesource.com/skia/+/c8e8fc6e98e9272293fcf24d53428ddd6129b011

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -26 lines)			Patch
M	BUILD.public	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkMath.cpp	View	2 chunks	+14 lines, -24 lines	0 comments	Download
M	tools/dm_flags.json	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	tools/dm_flags.py	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457863002/1

5 years, 1 month ago (2015-11-18 22:00:40 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457863002/1

5 years, 1 month ago (2015-11-18 22:00:58 UTC) #3

commit-bot: I haz the power

5 years, 1 month ago (2015-11-18 22:01:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c8e8fc6e98e9272293fcf24d53428ddd6129b011

Expand Messages | Collapse Messages