Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1457843003: Revert of Add noBarrierStore to WTF and use it for spinlocks (Closed)

Created:
5 years, 1 month ago by Alexander Potapenko
Modified:
5 years, 1 month ago
Reviewers:
haraken, jschuh
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add noBarrierStore to WTF and use it for spinlocks (patchset #2 id:20001 of https://codereview.chromium.org/1461743002/ ) Reason for revert: This CL broke compilation on the TSan bot. Please consider using the linux_clang_tsan trybot or building locally with GYP_DEFINES=tsan=1 next time. Original issue's description: > Add noBarrierStore to WTF and use it for spinlocks > > This will eliminate TSAN warnings on some benign races, > and help ensure that they remain benign. > > BUG=556469 > > Committed: https://crrev.com/12678ed8e9f993cbe343ddd3d08ee174244b6552 > Cr-Commit-Position: refs/heads/master@{#360481} TBR=haraken@chromium.org,jschuh@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=556469 Committed: https://crrev.com/cedffc5c367344c8018b791c644f9756fc88fb98 Cr-Commit-Position: refs/heads/master@{#360560}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -13 lines) Patch
M third_party/WebKit/Source/wtf/Atomics.h View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/wtf/SpinLock.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Alexander Potapenko
Created Revert of Add noBarrierStore to WTF and use it for spinlocks
5 years, 1 month ago (2015-11-19 11:24:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457843003/1
5 years, 1 month ago (2015-11-19 11:24:09 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 11:24:45 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cedffc5c367344c8018b791c644f9756fc88fb98 Cr-Commit-Position: refs/heads/master@{#360560}
5 years, 1 month ago (2015-11-19 11:25:24 UTC) #4
haraken
5 years, 1 month ago (2015-11-19 11:50:06 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698