Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 145783003: [GCM] Disable leaky tests (Closed)

Created:
6 years, 11 months ago by Nicolas Zea
Modified:
6 years, 11 months ago
Reviewers:
jianli
CC:
chromium-reviews
Visibility:
Public.

Description

[GCM] Disable leaky tests gcm_unit_tests fails on linux_asan. See bug. R=jianli@chromium.org TBR=jianli@chromium.org BUG=337560 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246680

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -4 lines) Patch
M google_apis/gcm/engine/gcm_store_impl_unittest.cc View 1 3 chunks +21 lines, -3 lines 0 comments Download
M google_apis/gcm/engine/mcs_client_unittest.cc View 1 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Nicolas Zea
PTAL
6 years, 11 months ago (2014-01-23 20:24:41 UTC) #1
jianli
lgtm
6 years, 11 months ago (2014-01-23 20:34:32 UTC) #2
Nicolas Zea
6 years, 11 months ago (2014-01-23 20:43:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r246680 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698