Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1457823002: Disable the ChromeVox menu button until it's complete. (Closed)

Created:
5 years, 1 month ago by dmazzoni
Modified:
5 years, 1 month ago
Reviewers:
David Tseng
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable the ChromeVox menu button until it's complete. Currently it just blacks the screen so we should disable it until the implementation is complete. BUG=557918 Committed: https://crrev.com/f2b2ff9cfbf754a464fe6c440e9be0798b12e24d Cr-Commit-Position: refs/heads/master@{#360612}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.html View 1 chunk +0 lines, -3 lines 2 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js View 2 chunks +4 lines, -9 lines 0 comments Download

Depends on Patchset:

Issue 1200133002 Patch 1

Messages

Total messages: 8 (2 generated)
dmazzoni
5 years, 1 month ago (2015-11-18 19:54:10 UTC) #2
David Tseng
lgtm https://codereview.chromium.org/1457823002/diff/1/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.html File chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.html (left): https://codereview.chromium.org/1457823002/diff/1/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.html#oldcode44 chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.html:44: #menu:hover { Meant to be part of this ...
5 years, 1 month ago (2015-11-19 16:46:06 UTC) #3
dmazzoni
https://codereview.chromium.org/1457823002/diff/1/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.html File chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.html (left): https://codereview.chromium.org/1457823002/diff/1/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.html#oldcode44 chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.html:44: #menu:hover { On 2015/11/19 16:46:06, David Tseng wrote: > ...
5 years, 1 month ago (2015-11-19 17:13:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457823002/1
5 years, 1 month ago (2015-11-19 17:14:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 17:19:56 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 17:20:52 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f2b2ff9cfbf754a464fe6c440e9be0798b12e24d
Cr-Commit-Position: refs/heads/master@{#360612}

Powered by Google App Engine
This is Rietveld 408576698