cc:: Don't use cached screen space transform for layers not in RSLL.

cc:: Don't use cached screen space transform for layers not in RSLL.

layer_tree_impl.cc and layer_tree_host_impl.cc make calls to
LayerImpl::screen_space_transform. When we use property trees, only
the layers that are in render surface layer list(RSLL) have the correct
cached screen space transform. For other layers, we need to calculate it
directly from property trees.

BUG=557942
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/90781febc9afac41c1feb79fd1b60f6c13864aa0
Cr-Commit-Position: refs/heads/master@{#360516}

[jaydasika, 2015-11-18 22:38:05]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org

[ajuma, 2015-11-18 23:03:42]

Please also add a cc unit test for this.

https://codereview.chromium.org/1457803003/diff/1/cc/trees/layer_tree_host_im...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/1457803003/diff/1/cc/trees/layer_tree_host_im...
cc/trees/layer_tree_host_impl.cc:2587:
layer_tree_impl->settings().verify_property_trees;
You can use settings_ here, no need to go through the LayerTreeImpl (since that
just asks LTHI for its settings).

[jaydasika, 2015-11-19 01:04:26]

Patchset #3 (id:40001) has been deleted

[jaydasika, 2015-11-19 01:10:11]

https://codereview.chromium.org/1457803003/diff/1/cc/trees/layer_tree_host_im...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/1457803003/diff/1/cc/trees/layer_tree_host_im...
cc/trees/layer_tree_host_impl.cc:2587:
layer_tree_impl->settings().verify_property_trees;
On 2015/11/18 23:03:42, ajuma wrote:
> You can use settings_ here, no need to go through the LayerTreeImpl (since
that
> just asks LTHI for its settings).

Done.

https://codereview.chromium.org/1457803003/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_impl_unittest.cc (left):

https://codereview.chromium.org/1457803003/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_impl_unittest.cc:4744:
scroll_layer->SetDrawsContent(true);
We already have a lot of unit test coverage for the changes in this patch. Any
test calling 'ScrollBy' hits the changes by this patch. But, the bug is not
exposed because use_property_trees = false and scroll layer draws content in
most of those tests. So, to test the changes in this patch, I have made use
property trees = true and made scroll layer not draw content in one of the
tests. This modified test fails without the patch.

[ajuma, 2015-11-19 01:52:04]

Thanks, lgtm with a nit:

https://codereview.chromium.org/1457803003/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_impl_unittest.cc (right):

https://codereview.chromium.org/1457803003/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_impl_unittest.cc:103: settings.use_property_trees =
true;
I'd prefer removing this and leaving the settings as-is, so that these tests
switch over to property trees at the same time as other tests.

[jaydasika, 2015-11-19 03:31:12]

The CQ bit was checked by jaydasika@chromium.org

[jaydasika, 2015-11-19 03:31:12]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/1457803003/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-11-19 03:33:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1457803003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1457803003/60001

[commit-bot: I haz the power, 2015-11-19 03:38:52]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-11-19 03:39:42]

Patchset 3 (id:??) landed as
https://crrev.com/90781febc9afac41c1feb79fd1b60f6c13864aa0
Cr-Commit-Position: refs/heads/master@{#360516}