Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Unified Diff: pkg/serialization/lib/serialization.dart

Issue 14578008: Add a DateTimeRule to default serialization (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/serialization/lib/serialization.dart
diff --git a/pkg/serialization/lib/serialization.dart b/pkg/serialization/lib/serialization.dart
index 58658405499f2d8640bba09353f1e97d5bf721eb..1731d559e3faa3c435412987ca7d00af65d773b1 100644
--- a/pkg/serialization/lib/serialization.dart
+++ b/pkg/serialization/lib/serialization.dart
@@ -258,8 +258,13 @@ class Serialization {
bool get selfDescribing {
// TODO(alanknight): Should this be moved to the format?
// TODO(alanknight): Allow self-describing in the presence of CustomRule.
+ // TODO(alanknight): Don't do duplicate work creating a writer and
+ // serialization here and then re-creating when we actually serialize.
if (_selfDescribing != null) return _selfDescribing;
- _selfDescribing = !rules.any((x) => x is CustomRule && x is! SymbolRule);
+ var meta = ruleSerialization();
+ var w = meta.newWriter();
+ _selfDescribing = !rules.any((rule) =>
+ meta.rulesFor(rule, w, false).isEmpty);
return _selfDescribing;
}
@@ -338,6 +343,7 @@ class Serialization {
addRule(new ListRuleEssential());
addRule(new MapRule());
addRule(new SymbolRule());
+ addRule(new DateTimeRule());
}
/**
@@ -394,7 +400,7 @@ class Serialization {
* Return the list of SerializationRule that apply to [object]. For
* internal use, but public because it's used in testing.
*/
- Iterable<SerializationRule> rulesFor(object, Writer w) {
+ Iterable<SerializationRule> rulesFor(object, Writer w, [create = true]) {
Jennifer Messerly 2013/05/14 23:18:33 consider: named argument here, they tend to be a b
Alan Knight 2013/05/14 23:32:55 Done.
// This has a couple of edge cases.
// 1) The owning object may have indicated we should use a different
// rule than the default.
@@ -422,7 +428,7 @@ class Serialization {
(each) => each.appliesTo(target, w));
if (applicable.isEmpty) {
- return [addRuleFor(target)];
+ return create ? [addRuleFor(target)] : applicable;
}
if (applicable.length == 1) return applicable;
@@ -466,7 +472,8 @@ class Serialization {
..addRule(new NamedObjectRule())
..addRule(new MirrorRule())
..addRuleFor(new MirrorRule())
- ..addRuleFor(new SymbolRule());
+ ..addRuleFor(new SymbolRule())
+ ..addRuleFor(new DateTimeRule());
meta.namedObjects = namedObjects;
return meta;
}
« no previous file with comments | « no previous file | pkg/serialization/lib/src/serialization_rule.dart » ('j') | pkg/serialization/lib/src/serialization_rule.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698