Support range uploading of a file.

net/url_request/url_fetcher.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_URL_REQUEST_URL_FETCHER_H_
 #define NET_URL_REQUEST_URL_FETCHER_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 123 matching lines @@
   // call one of the SetUpload* methods before the request is started.
   // |upload_content_type| is the MIME type of the content, while
   // |file_path| is the path to the file containing the data to be sent (the
   // Content-Length header value will be set to the length of this file).
   // |file_task_runner| will be used for all file operations.
   virtual void SetUploadFilePath(
       const std::string& upload_content_type,
       const base::FilePath& file_path,
       scoped_refptr<base::TaskRunner> file_task_runner) = 0;
 
+  // Sets data only needed by POSTs as same as SetUploadFilePath().
+  // The only difference is that this method takes the |range_offset| and
+  // |range_length| to upload a part of the file at |file_path|.
+  virtual void SetUploadFilePathWithRange(
+      const std::string& upload_content_type,
+      const base::FilePath& file_path,
+      uint64 range_offset,
+      uint64 range_length,

[hashimoto, 2013/04/30 10:27:36]

Instead of adding a new method, can we add these range parameters to
SetUploadFilePath?
The method is used by only one user, two_phase_uploader.cc.

[hidehiko, 2013/04/30 11:30:14]

We can, but should we do that?
I'm thinking that setting (0, kuint64max) at client side (to upload whole the
file) may not good stuff because it's just the implementation details. WDYT?

[hashimoto, 2013/05/01 06:39:21]

I don't think we should maintain two unpopular methods at the same time which
has only one user for each.

Historically, SetUploadFilePath was introduced because the attempt to add more
general SetUploadDataStream method had failed due to the problem around retry.
(http://crbug.com/169551)
I think setting kuint64max is not beautiful but acceptable because
SetUploadFilePath is meant to be an alternative for manual setup of
UploadFileElementReader.

[hidehiko, 2013/05/01 13:51:49]

Ok. Done.

+      scoped_refptr<base::TaskRunner> file_task_runner) = 0;
+
   // Indicates that the POST data is sent via chunked transfer encoding.
   // This may only be called before calling Start().
   // Use AppendChunkToUpload() to give the data chunks after calling Start().
   virtual void SetChunkedUpload(const std::string& upload_content_type) = 0;
 
   // Adds the given bytes to a request's POST data transmitted using chunked
   // transfer encoding.
   // This method should be called ONLY after calling Start().
   virtual void AppendChunkToUpload(const std::string& data,
                                    bool is_last_chunk) = 0;
@@ skipping 133 matching lines @@
   // be removed once the URLFetcher is destroyed.  User should not take
   // ownership more than once, or call this method after taking ownership.
   virtual bool GetResponseAsFilePath(
       bool take_ownership,
       base::FilePath* out_response_path) const = 0;
 };
 
 }  // namespace net
 
 #endif  // NET_URL_REQUEST_URL_FETCHER_H_