Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1457793004: unbreak the no-webrtc build (Closed)

Created:
5 years, 1 month ago by Mostyn Bramley-Moore
Modified:
5 years, 1 month ago
Reviewers:
Sergey Ulanov, kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

unbreak the no-webrtc build Followup to https://codereview.chromium.org/1427003009 The third_party/libjingle/libjingle.gyp:libjingle_webrtc target is defined inside an enable_webrtc==1 condition, so it can only be depended on inside a similar condition. BUG=547158 Committed: https://crrev.com/5938eeb0b396cca5014d73085fcb8c0d80cd20a5 Cr-Commit-Position: refs/heads/master@{#360646}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M remoting/remoting.gyp View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457793004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457793004/1
5 years, 1 month ago (2015-11-19 05:19:51 UTC) #2
Mostyn Bramley-Moore
@kelvinp, Sergey: please take a look at this fixup for CL1427003009.
5 years, 1 month ago (2015-11-19 05:20:42 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-19 05:59:04 UTC) #6
Sergey Ulanov
lgtm
5 years, 1 month ago (2015-11-19 19:43:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457793004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457793004/1
5 years, 1 month ago (2015-11-19 19:45:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 20:06:27 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 20:07:24 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5938eeb0b396cca5014d73085fcb8c0d80cd20a5
Cr-Commit-Position: refs/heads/master@{#360646}

Powered by Google App Engine
This is Rietveld 408576698