Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1457783004: port I411 movzx 2 byte reader to gcc (Closed)

Created:
5 years, 1 month ago by fbarchard1
Modified:
5 years, 1 month ago
Reviewers:
harryjin
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

port I411 movzx 2 byte reader to gcc previously the I411 format used movd to read U, V pixels. But this reads 4 bytes, and can cause a memory exception. pinsrw can be used, but fails on drmemory 1.5, and is slow. So in this change a movzxw is used to read 2 bytes into EBX, then copy to xmm0 with movd. Slightly slower, but no memory exception Was LibYUVConvertTest.I411ToARGB_Opt (577 ms) Now LibYUVConvertTest.I411ToARGB_Opt (608 ms) TBR=harryjin@google.com BUG=libyuv:525 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/50f8cb2db33f563b290a2831b3aecbf357a44e32

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/version.h View 1 chunk +1 line, -1 line 0 comments Download
M source/row_gcc.cc View 3 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fbarchard1
5 years, 1 month ago (2015-11-18 21:05:27 UTC) #1
fbarchard1
5 years, 1 month ago (2015-11-18 21:05:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
50f8cb2db33f563b290a2831b3aecbf357a44e32 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698