Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: chrome/browser/ui/views/desktop_media_picker_views.cc

Issue 1457743002: Show error message for desktop capture related APIs on Aura Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: reviews Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/desktop_media_picker_views.cc
diff --git a/chrome/browser/ui/views/desktop_media_picker_views.cc b/chrome/browser/ui/views/desktop_media_picker_views.cc
index 7c438b20b530dd6999cc66e3a07897776559586f..c3ec6abaec588b3294fda8f6acc89a4dce44dfb5 100644
--- a/chrome/browser/ui/views/desktop_media_picker_views.cc
+++ b/chrome/browser/ui/views/desktop_media_picker_views.cc
@@ -52,7 +52,9 @@ const char kDesktopMediaSourceViewClassName[] =
DesktopMediaID::Id AcceleratedWidgetToDesktopMediaId(
gfx::AcceleratedWidget accelerated_widget) {
-#if defined(OS_WIN)
+#if defined(OS_WIN) || defined(OS_ANDROID)
sky 2015/11/19 20:40:41 Is it worth a NOT_IMPLEMENTED() for android?
bshe 2015/11/20 15:44:29 Done.
+ // TODO(bshe): We may need to revisit this for Android platform. See
+ // crbug.com/557424.
return reinterpret_cast<DesktopMediaID::Id>(accelerated_widget);
#else
return static_cast<DesktopMediaID::Id>(accelerated_widget);
« no previous file with comments | « chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698