Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Unified Diff: chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc

Issue 1457743002: Show error message for desktop capture related APIs on Aura Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/desktop_media_picker_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc
diff --git a/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc b/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc
index 22302a1434cfca5002a992174da5175257cf79e0..bc2601e1e4c16864774d5161c54c7658c17f8f4c 100644
--- a/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc
+++ b/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc
@@ -128,7 +128,11 @@ bool DesktopCaptureChooseDesktopMediaFunctionBase::Execute(
// DesktopMediaPicker is implemented only for Windows, OSX and
// Aura Linux builds.
-#if defined(TOOLKIT_VIEWS) || defined(OS_MACOSX)
+#if defined(TOOLKIT_VIEWS) && !defined(OS_ANDROID) || defined(OS_MACOSX)
mfomitchev 2015/11/19 15:56:55 Note that Dan is adding a new ANDROID_JAVA_UI defi
mfomitchev 2015/11/19 15:56:55 Can you please add braces here so that it is more
bshe 2015/11/19 20:14:38 Done.
bshe 2015/11/19 20:14:38 Added a TODO.
+ // TODO(bshe): This is called if chrome.desktopCapture.chooseDesktopMedia
+ // or chrome.webrtcDesktopCapturePrivate.chooseDesktopMedia are called by
+ // extensions. Simply return error message on Android platform for now.
+ // Revisit this when necessary. See crbug.com/557424.
picker_ = DesktopMediaPicker::Create();
#else
error_ = "Desktop Capture API is not yet implemented for this platform.";
« no previous file with comments | « no previous file | chrome/browser/ui/views/desktop_media_picker_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698