Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Unified Diff: third_party/protobuf/protobuf.gyp

Issue 14577007: Gyp changes for ninja iOS build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Handle ninja-ios type in landmines Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« testing/iossim/iossim.gyp ('K') | « testing/iossim/iossim.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/protobuf/protobuf.gyp
diff --git a/third_party/protobuf/protobuf.gyp b/third_party/protobuf/protobuf.gyp
index 772bc1060e329ba4014f2aa7e26574b3f9d08f10..bbe602160c8fe9d7bf4450c57ffad52386dc2477 100644
--- a/third_party/protobuf/protobuf.gyp
+++ b/third_party/protobuf/protobuf.gyp
@@ -57,7 +57,11 @@
{
'action_name': 'compile protoc',
'inputs': [],
- 'outputs': [],
+ # A nonexistant name forces the ninja cmd every time.
Mark Mentovai 2013/05/01 18:12:10 Here too.
+ 'outputs': [
+ '<(ninja_product_dir)/protoc',
Mark Mentovai 2013/05/01 18:12:10 So what…a real output and a fake output? Why?
+ 'compile_protoc'
+ ],
'action': [
'<@(ninja_cmd)',
'protoc',
« testing/iossim/iossim.gyp ('K') | « testing/iossim/iossim.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698