Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: breakpad/breakpad.gyp

Issue 14577007: Gyp changes for ninja iOS build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Handle ninja-ios type in landmines Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/common.gypi » ('j') | build/common.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: breakpad/breakpad.gyp
diff --git a/breakpad/breakpad.gyp b/breakpad/breakpad.gyp
index 80fd6775e2fd253812c716c69bf8f8d74b57c5cc..4609298c7400b089565d041872be0d7afd0f1c8e 100644
--- a/breakpad/breakpad.gyp
+++ b/breakpad/breakpad.gyp
@@ -696,7 +696,8 @@
{
'action_name': 'compile breakpad utilities',
'inputs': [],
- 'outputs': [],
+ # A nonexistant name forces the ninja cmd every time.
Mark Mentovai 2013/05/01 18:12:10 spelling: nonexistent spelling: command, not cmd
+ 'outputs': ['compile_breakpad_utilities'],
stuartmorgan 2013/05/01 14:03:42 No outputs should also force it every time. What p
justincohen 2013/05/01 14:08:57 ninja doesn't like no outputs. On 2013/05/01 14:0
'action': [
'<@(ninja_cmd)',
'dump_syms',
« no previous file with comments | « no previous file | build/common.gypi » ('j') | build/common.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698