chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js - Issue 1457683009: Complete live region support in ChromeVox Next.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js

Issue 1457683009: Complete live region support in ChromeVox Next. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed last feedback Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/tabs_automation_handler.js ('k') | chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js

diff --git a/chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js b/chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js

index bc7744cae51c58e52a212918ae2ffc77be3a7a5d..d9d508957a5a7b2960d6a05d90a9b695e152629e 100644

--- a/chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js

+++ b/chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js

@@ -73,7 +73,8 @@ ChromeVoxE2ETest.prototype = {

/**

* Launches the given document in a new tab.

* @param {function() : void} doc Snippet wrapped inside of a function.

- * @param {function()} opt_callback Called once the document is created.

+ * @param {function(url: string)} opt_callback Called once the

+ * document is created.

runWithTab: function(doc, opt_callback) {

var docString = TestUtils.extractHtmlFromCommentEncodedString(doc);

@@ -84,7 +85,10 @@ ChromeVoxE2ETest.prototype = {

active: true,

url: url

};

- chrome.tabs.create(createParams, opt_callback);

+ chrome.tabs.create(createParams, function(tab) {

+ if (opt_callback)

+ opt_callback(tab.url);

+ });

/**