Complete live region support in ChromeVox Next.

chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Handles automation from a desktop automation node.
  */
 
 goog.provide('DesktopAutomationHandler');
 
@@ skipping 45 matching lines @@
    * @param {Object} evt
    */
   onEventDefault: function(evt) {
     var node = evt.target;
 
     if (!node)
       return;
 
     var prevRange = global.backgroundObj.currentRange;
 
-    global.backgroundObj.currentRange = cursors.Range.fromNode(node);
+    global.backgroundObj.setCurrentRange(cursors.Range.fromNode(node));

[David Tseng, 2015/11/23 23:23:57]

Chang this to ChromeVoxState.

[dmazzoni, 2015/11/23 23:51:02]

Should Background pass ChromeVoxState to the DesktopAutomationHandler
constructor, or should there be a global.chromeVoxState that can be accessed
from anywhere?

I'm somewhat leaning towards trying to do everything with dependency injection,
it could benefit testing.

[dmazzoni, 2015/11/30 22:00:47]

OK, I made ChromeVoxState a singleton for now because it wasn't obvious how to
pass the cvox2 background into the constructor from TabsApiHandler.

 
     // Check to see if we've crossed roots. Continue if we've crossed roots or
     // are not within web content.
     if (node.root.role == RoleType.desktop ||
         !prevRange ||
         prevRange.start.node.root != node.root)
       global.backgroundObj.refreshMode(node.root.docUrl || '');
 
     // Don't process nodes inside of web content if ChromeVox Next is inactive.
     if (node.root.role != RoleType.desktop &&
@@ skipping 98 matching lines @@
       webView = webView.parent;
 
     if (!webView || !webView.state.focused)
       return;
 
     var node = AutomationUtil.findNodePost(root,
         Dir.FORWARD,
         AutomationPredicate.leaf);
 
     if (node)
-      global.backgroundObj.currentRange = cursors.Range.fromNode(node);
+      global.backgroundObj.setCurrentRange(cursors.Range.fromNode(node));
 
     if (global.backgroundObj.currentRange)
       new Output().withSpeechAndBraille(
               global.backgroundObj.currentRange, null, evt.type)
           .go();
   },
 
   /**
    * Provides all feedback once a text selection change event fires.
    * @param {Object} evt
    */
   onTextOrTextSelectionChanged: function(evt) {
     if (!this.isEditable_(evt.target))
       return;
 
     // Don't process nodes inside of web content if ChromeVox Next is inactive.
     if (evt.target.root.role != RoleType.desktop &&
         global.backgroundObj.mode === ChromeVoxMode.CLASSIC)
       return;
 
     if (!evt.target.state.focused)
       return;
 
     if (!global.backgroundObj.currentRange) {
       this.onEventDefault(evt);
-      global.backgroundObj.currentRange = cursors.Range.fromNode(evt.target);
+      global.backgroundObj.setCurrentRange(cursors.Range.fromNode(evt.target));
     }
 
     this.createEditableTextHandlerIfNeeded_(evt.target);
 
     var textChangeEvent = new cvox.TextChangeEvent(
         evt.target.value,
         evt.target.textSelStart,
         evt.target.textSelEnd,
         true);  // triggered by user
 
@@ skipping 13 matching lines @@
     if (evt.target.root.role != RoleType.desktop &&
         global.backgroundObj.mode === ChromeVoxMode.CLASSIC)
       return;
 
     if (!evt.target.state.focused)
       return;
 
     // Value change events fire on web editables when typing. Suppress them.
     if (!global.backgroundObj.currentRange || !this.isEditable_(evt.target)) {
       this.onEventDefault(evt);
-      global.backgroundObj.currentRange = cursors.Range.fromNode(evt.target);
+      global.backgroundObj.setCurrentRange(cursors.Range.fromNode(evt.target));
     }
   },
 
   /**
    * Handle updating the active indicator when the document scrolls.
    * @override
    */
   onScrollPositionChanged: function(evt) {
     var currentRange = global.backgroundObj.currentRange;
     if (currentRange)
@@ skipping 46 matching lines @@
   if (cvox.ChromeVox.isMac)
     return;
   chrome.automation.getDesktop(function(desktop) {
     global.desktopAutomationHandler = new DesktopAutomationHandler(desktop);
   });
 };
 
 DesktopAutomationHandler.init_();
 
 });  // goog.scope