Complete live region support in ChromeVox Next.

chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview ChromeVox utilities for the automation extension API.
  */
 
 goog.provide('AutomationUtil');
 goog.provide('AutomationUtil.Dir');
@@ skipping 258 matching lines @@
       return true;
     case RoleType.toolbar:
       return node.root.role == RoleType.desktop;
     case RoleType.rootWebArea:
       return !!(node.parent && node.parent.root.role == RoleType.desktop);
     default:
       return false;
   }
 };
 
+/**
+ * Determines whether the two given nodes come from the same webpage.
+ * @param {AutomationNode} a
+ * @param {AutomationNode} b
+ * @return {boolean}
+ */
+AutomationUtil.isInSameWebpage = function(a, b) {

[Peter Lundblad, 2015/11/20 13:42:58]

Could you add a unit test for this one?

[dmazzoni, 2015/11/23 20:16:50]

Sure, done. I had to modify runWithLoadedTree to support loading multiple tabs.
That might be useful for future tests.

+  if (!a || !b)
+    return false;
+
+  a = a.root;
+  while (a) {

[Peter Lundblad, 2015/11/20 13:42:58]

nit:
while (a && a.parent && AutomationUtil.isInSameTree(a.parent, a))

[dmazzoni, 2015/11/23 20:16:50]

Done.

+    if (!a.parent)
+      break;
+    if (!AutomationUtil.isInSameTree(a.parent, a))
+      break;
+    a = a.parent.root;
+  }
+
+  b = b.root;
+  while (b) {

[Peter Lundblad, 2015/11/20 13:42:58]

Consider adding a utility function for this.

[dmazzoni, 2015/11/23 20:16:50]

Doesn't seem necessary now that it's a one-line loop and wouldn't be needed
elsewhere. Let me know if you'd still prefer that.

+    if (!b.parent)
+      break;
+    if (!AutomationUtil.isInSameTree(b.parent, b))
+      break;
+    b = b.parent.root;
+  }
+
+  return a == b;
+};
+
 });  // goog.scope