Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1457683002: Remove Chrome OS Mirror UI. Part 2. (Closed)

Created:
5 years, 1 month ago by dzhioev (left Google)
Modified:
5 years, 1 month ago
Reviewers:
achuithb
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Chrome OS Mirror UI. Part 2. InlineLoginDialog removed. BUG=546731 Committed: https://crrev.com/c694a0222bb0e9902a43aef35b799d27fa1861a5 Cr-Commit-Position: refs/heads/master@{#360448}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -128 lines) Patch
D chrome/browser/chromeos/ui/inline_login_dialog.h View 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/browser/chromeos/ui/inline_login_dialog.cc View 1 chunk +0 lines, -81 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dzhioev (left Google)
Hi, PTAL
5 years, 1 month ago (2015-11-18 01:19:55 UTC) #2
achuithb
lgtm
5 years, 1 month ago (2015-11-18 01:22:33 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457683002/1
5 years, 1 month ago (2015-11-18 01:23:30 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-18 02:09:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457683002/1
5 years, 1 month ago (2015-11-18 23:06:58 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-18 23:58:16 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 23:59:48 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c694a0222bb0e9902a43aef35b799d27fa1861a5
Cr-Commit-Position: refs/heads/master@{#360448}

Powered by Google App Engine
This is Rietveld 408576698