Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1457673003: X87: Handle StepIn for constructors through PrepareStep just like for regular calls. (Closed)

Created:
5 years, 1 month ago by zhengxing.li
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Handle StepIn for constructors through PrepareStep just like for regular calls. port 14ec485c3a2887af22e17fb3906215d9a02f5e83 (r32044) original commit message: BUG= Committed: https://crrev.com/30d6a4deb256e421f0188e9ea5fdd3f6c6363e5e Cr-Commit-Position: refs/heads/master@{#32073}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -23 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M src/x87/builtins-x87.cc View 2 chunks +0 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zhengxing.li
5 years, 1 month ago (2015-11-18 06:15:03 UTC) #2
Weiliang
lgtm
5 years, 1 month ago (2015-11-18 08:12:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457673003/1
5 years, 1 month ago (2015-11-18 08:13:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-18 08:32:12 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 08:32:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/30d6a4deb256e421f0188e9ea5fdd3f6c6363e5e
Cr-Commit-Position: refs/heads/master@{#32073}

Powered by Google App Engine
This is Rietveld 408576698