Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 1457673002: styleguide: Allow enable_if, conditional, and other type_traits. (Closed)

Created:
5 years, 1 month ago by vmpstr
Modified:
5 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

styleguide: Allow enable_if, conditional, and other type_traits. R=thakis@chromium.org Committed: https://crrev.com/c52317fc311d2193dc880f5b4ce09b30c8d90269 Cr-Commit-Position: refs/heads/master@{#360310}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rare usage note #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -40 lines) Patch
M base/bind_internal.h View 3 chunks +8 lines, -6 lines 0 comments Download
M base/callback_internal.h View 3 chunks +3 lines, -14 lines 0 comments Download
M styleguide/c++/c++11.html View 1 3 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
vmpstr
Please take a look.
5 years, 1 month ago (2015-11-18 00:23:28 UTC) #1
Nico
lgtm, thanks! https://codereview.chromium.org/1457673002/diff/1/styleguide/c++/c++11.html File styleguide/c++/c++11.html (right): https://codereview.chromium.org/1457673002/diff/1/styleguide/c++/c++11.html#newcode309 styleguide/c++/c++11.html:309: <td><a href='https://groups.google.com/a/chromium.org/forum/#!topic/cxx/vCxo4tZNd_M'>Discussion thread</a></td> like the other one ...
5 years, 1 month ago (2015-11-18 01:38:19 UTC) #2
vmpstr
https://codereview.chromium.org/1457673002/diff/1/styleguide/c++/c++11.html File styleguide/c++/c++11.html (right): https://codereview.chromium.org/1457673002/diff/1/styleguide/c++/c++11.html#newcode309 styleguide/c++/c++11.html:309: <td><a href='https://groups.google.com/a/chromium.org/forum/#!topic/cxx/vCxo4tZNd_M'>Discussion thread</a></td> On 2015/11/18 01:38:19, Nico wrote: > ...
5 years, 1 month ago (2015-11-18 05:44:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457673002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457673002/20001
5 years, 1 month ago (2015-11-18 05:44:38 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-18 08:43:33 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 08:44:47 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c52317fc311d2193dc880f5b4ce09b30c8d90269
Cr-Commit-Position: refs/heads/master@{#360310}

Powered by Google App Engine
This is Rietveld 408576698