Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Issue 1457643002: Fix for mapping SDK files to 'dart:' URIs. (Closed)

Created:
5 years, 1 month ago by scheglov
Modified:
5 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -32 lines) Patch
M pkg/analysis_server/lib/src/domain_execution.dart View 1 chunk +5 lines, -1 line 0 comments Download
M pkg/analysis_server/test/domain_execution_test.dart View 5 chunks +58 lines, -31 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 1 month ago (2015-11-17 23:15:50 UTC) #1
Brian Wilkerson
LGTM
5 years, 1 month ago (2015-11-17 23:47:33 UTC) #2
scheglov
5 years, 1 month ago (2015-11-18 01:20:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4ed3afeb5edac86fd2afc2cb3a23d6f83533b253 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698