Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1696)

Unified Diff: third_party/WebKit/LayoutTests/animations/big-number-clamping.html

Issue 1457623003: Clamp animated numbers according to ComputedStyle data type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update test Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/animations/big-number-clamping.html
diff --git a/third_party/WebKit/LayoutTests/animations/big-number-clamping.html b/third_party/WebKit/LayoutTests/animations/big-number-clamping.html
new file mode 100644
index 0000000000000000000000000000000000000000..d6a8f67a8be1ed308172df6a18afcfc5df5c4f6b
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/animations/big-number-clamping.html
@@ -0,0 +1,35 @@
+<!DOCTYPE html>
+<script src="../resources/testharness.js"></script>
+<script src="../resources/testharnessreport.js"></script>
+<style>
+div {
+ /* This is required so that z-index doesn't compute as auto. */
+ position: relative;
+}
+</style>
+
+<div id="animated"></div>
+<div id="reference"></div>
+
+<script>
+var numberProperties = [
+ 'flex-grow',
+ 'flex-shrink',
+ 'font-size-adjust',
+ 'line-height',
+ 'orphans',
+ 'stroke-miterlimit',
+ 'widows',
+ 'z-index',
+];
+
+var bigNumber = 1e20;
+
+for (property of numberProperties) {
+ test(() => {
+ animated.animate({[property]: bigNumber}, {fill: 'forwards'});
+ reference.style[property] = bigNumber;
+ assert_equals(getComputedStyle(animated)[property], getComputedStyle(reference)[property]);
+ }, `Animations on ${property} should clamp identically to setting inline style`);
+}
+</script>

Powered by Google App Engine
This is Rietveld 408576698