Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1578)

Unified Diff: appengine/isolate/handlers_api.py

Issue 1457613002: Add alerts on all old APIs on both Swarming and Isolate servers. (Closed) Base URL: git@github.com:luci/luci-py.git@0_test
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | appengine/swarming/handlers_api.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/isolate/handlers_api.py
diff --git a/appengine/isolate/handlers_api.py b/appengine/isolate/handlers_api.py
index b76408af7c80ab4987137fcac44f0cc778a735de..ead3951f572ae986d7957c132673c5fc5f3bd305 100644
--- a/appengine/isolate/handlers_api.py
+++ b/appengine/isolate/handlers_api.py
@@ -165,6 +165,7 @@ class HandshakeHandler(ProtocolHandler):
@auth.require(acl.isolate_readable)
def post(self):
"""Responds with access token and server version."""
+ logging.error('Unexpected old client')
try:
request = json.loads(self.request.body)
client_protocol = str(request['protocol_version'])
@@ -374,6 +375,7 @@ class PreUploadContentHandler(ProtocolHandler):
@auth.require(acl.isolate_writable)
def post(self, namespace):
"""Reads body with items to upload and replies with URLs to upload to."""
+ logging.error('Unexpected old client')
if not re.match(r'^%s$' % model.NAMESPACE_RE, namespace):
self.send_error(
'Invalid namespace; allowed keys must pass regexp "%s"' %
@@ -423,6 +425,7 @@ class RetrieveContentHandler(ProtocolHandler):
@auth.require(acl.isolate_readable)
def get(self, namespace, hash_key): #pylint: disable=W0221
+ logging.error('Unexpected old client')
# Parse 'Range' header if it's present to extract initial offset.
# Only support single continuous range from some |offset| to the end.
offset = 0
@@ -524,6 +527,7 @@ class StoreContentHandler(ProtocolHandler):
@auth.require(acl.isolate_writable)
def post(self, namespace, hash_key):
"""POST is used when finalizing upload to GS."""
+ logging.error('Unexpected old client')
return self.handle(namespace, hash_key)
@auth.require(acl.isolate_writable)
« no previous file with comments | « no previous file | appengine/swarming/handlers_api.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698