In WinAura, also kill the Metro viewer process in AttemptExit().

chrome/browser/browser_process_platform_part_base.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browser_process_platform_part_base.h"
+#include "chrome/browser/lifetime/application_lifetime.h"
 
 BrowserProcessPlatformPartBase::BrowserProcessPlatformPartBase() {
 }
 
 BrowserProcessPlatformPartBase::~BrowserProcessPlatformPartBase() {
 }
 
 void BrowserProcessPlatformPartBase::PlatformSpecificCommandLineProcessing(
     const CommandLine& /* command_line */) {
 }
 
 void BrowserProcessPlatformPartBase::StartTearDown() {
 }
+
+void BrowserProcessPlatformPartBase::AttemptExit() {
+  // On most platforms, closing all windows causes the application to exit.
+  chrome::CloseAllBrowsers();

[sky, 2013/05/18 15:18:58]

I think its a little mysterious that you have this here and sometimes invoke it
(say aurawin) and sometimes don't (say android). But I can't think of a better
way:(

[gab, 2013/05/21 03:50:33]

While playing some more with the application lifetime code to try to fix
android/ios compile issues with this CL I found out that application_lifetime
already has platform specific files for HandleAppExitingForPlatform() [1].

It would probably make sense to put the platform-specific parts of AttemptExit()
in there instead of in BrowserProcessPlatformPart since only Winaura actually
needs to do work that requires state from the BrowserProcessPlatformPart
(metro_viewer_process_host_); this could be brought back as a WinAura specific
BrowserProcessPlatformPart::TerminateMetroViewerProcess() call as in patch set 5
and be called from application_lifetime_win.cc::AttemptExit() for USE_AURA/Win8+
only.

WDYT?
Either:
1) Keep the current paradigm and go through a generic AttemptExit() call in
g_browser_process for all platforms.
or 2) Make a generic AttemptExitForPlatform() call in an internals:: namespace
in the existing platform specific application_lifetime_* files and introduce a
WinAura only call BrowserProcessPlatformPart::TerminateMetroViewerProcess().


[1]
https://code.google.com/p/chromium/codesearch#search/&q=HandleAppExitingForPl...

[gab, 2013/05/21 15:39:30]

Actually, I still feel the current approach (1) is better, the
application_lifetime_* approach also has the issue that it uses a _stub.cc as a
base impl, but any platform not using the stub has to re-implement the default
behavior for methods it doesn't want to override...

Let me know what you think.

+}