In WinAura, also kill the Metro viewer process in AttemptExit().

chrome/browser/browser_process.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This interface is for managing the global services of the application. Each
 // service is lazily created when requested the first time. The service getters
 // will return NULL if the service is not available, so callers must check for
 // this condition.
 
 #ifndef CHROME_BROWSER_BROWSER_PROCESS_H_
@@ skipping 207 matching lines @@
   virtual chrome::MediaFileSystemRegistry* media_file_system_registry() = 0;
 
   virtual void PlatformSpecificCommandLineProcessing(
       const CommandLine& command_line) = 0;
 
   virtual bool created_local_state() const = 0;
 
 #if defined(OS_WIN) && defined(USE_AURA)
   // Invoked when the ASH metro viewer process on Windows 8 exits.
   virtual void OnMetroViewerProcessTerminated() = 0;
+
+  // Terminates the metro viewer process if there is one.
+  virtual void TerminateMetroViewerProcess() = 0;

[sky, 2013/05/14 17:17:51]

Move these two into a win-aura specific BrowserProcessPlatformPart. There isn't
one yet, so you'll have to create it. Follow the pattern of the chromeos
specific one.

[gab, 2013/05/14 17:45:25]

These methods need to have access to metro_viewer_process_host_ which is a
member of BrowserProcessImpl.

The only way I can think of to move these into a win-aura specific
BrowserProcessPlatformPart would be to pass a pointer the this pointer of
BrowserProcessImpl when constructing a BrowserProcessPlatformPart and making
BrowserProcessPlatformPart a friend of BrowserProcessImpl (or publicly expose a
non-const getter to the internal pointer =S), but that feels like a worst hack
than the current one...

WDYT?

[sky, 2013/05/14 20:47:45]

Can metro_viewer_process_host_ be moved too? Ideally this file would have no
ifdefs.

[gab, 2013/05/15 17:13:23]

Of course, not sure why I thought that wouldn't work... anyways did it in a
separate CL (https://codereview.chromium.org/14698027/) and rebased this one on
top of that one.

PTAL.

Thanks!
Gab

 #endif
 
  private:
   DISALLOW_COPY_AND_ASSIGN(BrowserProcess);
 };
 
 extern BrowserProcess* g_browser_process;
 
 #endif  // CHROME_BROWSER_BROWSER_PROCESS_H_