Add Mocha based tests for Settings pages

chrome/test/data/webui/settings/main_page_browsertest.js

Index: chrome/test/data/webui/settings/main_page_browsertest.js
diff --git a/chrome/test/data/webui/settings/main_page_browsertest.js b/chrome/test/data/webui/settings/main_page_browsertest.js
new file mode 100644
index 0000000000000000000000000000000000000000..c30a3660df0f7c175ea78d7951fb7fffa22b68dd
--- /dev/null
+++ b/chrome/test/data/webui/settings/main_page_browsertest.js
@@ -0,0 +1,63 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+/** @fileoverview Suite of tests for the Settings main page. */
+
+// Polymer BrowserTest fixture.

[michaelpg, 2015/11/18 02:00:32]

// SettingsPageBrowserTest. (or no comment)

[stevenjb, 2015/11/18 20:02:33]

Done.

+GEN_INCLUDE(['settings_page_browsertest.js']);
+
+/**
+ * @constructor
+ * @extends {PolymerTest}

[michaelpg, 2015/11/18 02:00:32]

{SettingsPageBrowserTest}

[stevenjb, 2015/11/18 20:02:33]

Done.

+*/
+function SettingsMainPageBrowserTest() {}
+
+SettingsMainPageBrowserTest.prototype = {
+  __proto__: SettingsPageBrowserTest.prototype,
+
+  registerTests: function() {
+    var self = this;
+    suite('SettingsPage', function() {
+      test('load page', function() {});
+
+      test('basic pages', function() {
+        var page = self.getPage('basic');
+        expectTrue(!!self.getSection(page, 'appearance'));
+        expectTrue(!!self.getSection(page, 'on-startup'));
+        expectTrue(!!self.getSection(page, 'search'));
+        if (!cr.isChromeOS) {
+          expectTrue(!!self.getSection(page, 'people'));
+          expectTrue(!!self.getSection(page, 'defaultBrowser'));
+        } else {
+          expectTrue(!!self.getSection(page, 'internet'));
+          expectTrue(!!self.getSection(page, 'users'));
+        }
+      });

[dpapad, 2015/11/18 01:44:54]

Nit: How about avoiding "var self = this" by just binding the function to the
"this".

test('Foo', function() {....}.bind(this));

[michaelpg, 2015/11/18 02:00:32]

Not binding was my suggestion. First of all it's annoying to have to do it for
every test and suite. Secondly, these functions, when called, already have a
non-global context.

Calls to suite() or test() result in a mocha Suite or Test object being created;
the passed function is then called *on* the created object, so "this" in a test
actually means something already.

You can use "this" to change properties of the suite or test (and all nested
suites/tests):
 * this.timeout(ms); // changes the timeout to a particular value
 * this.slow(ms); // changes the "slow" warning threshold, which I don't think
we use

source:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/mocha/...

[stevenjb, 2015/11/18 20:02:33]

Added a comment.

[dpapad, 2015/11/18 21:09:53]

Thanks for the information. Did not know that "this" is already bound to a
meaningful object by Mocha.

+
+      test('advanced pages', function() {
+        var page = self.getPage('advanced');
+        expectTrue(!!self.getSection(page, 'location'));
+        expectTrue(!!self.getSection(page, 'privacy'));
+        expectTrue(!!self.getSection(page, 'passwordsAndForms'));
+        expectTrue(!!self.getSection(page, 'languages'));
+        expectTrue(!!self.getSection(page, 'downloads'));
+        expectTrue(!!self.getSection(page, 'reset'));
+
+        if (cr.isChromeOS) {
+          expectTrue(!!self.getSection(page, 'dateTime'));
+          expectTrue(!!self.getSection(page, 'bluetooth'));
+          expectTrue(!!self.getSection(page, 'a11y'));
+        }
+      });
+    });
+  }
+};
+
+TEST_F('SettingsMainPageBrowserTest', 'Main', function() {
+  // Register mocha tests.
+  this.registerTests();

[michaelpg, 2015/11/18 02:00:32]

I don't see much of a reason to register these tests in a separate function --
they're all related to this TEST_F.

[stevenjb, 2015/11/18 20:02:33]

Done.

+
+  // Run all registered tests.
+  mocha.run();
+});