Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2421)

Unified Diff: chrome/browser/importer/ie_importer_browsertest_win.cc

Issue 14575004: Extract BookmarksFileImporter from Firefox2Importer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: test cleanup Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/importer/ie_importer_browsertest_win.cc
diff --git a/chrome/browser/importer/ie_importer_browsertest_win.cc b/chrome/browser/importer/ie_importer_browsertest_win.cc
index 6b319e967f47e4d637d027523cf580e8af511e80..3eb013235c9cf47d877c9b5d19046bf581f8913e 100644
--- a/chrome/browser/importer/ie_importer_browsertest_win.cc
+++ b/chrome/browser/importer/ie_importer_browsertest_win.cc
@@ -28,7 +28,8 @@
#include "base/win/scoped_comptr.h"
#include "base/win/scoped_propvariant.h"
#include "base/win/windows_version.h"
-#include "chrome/browser/history/history_types.h"
+#include "chrome/browser/bookmarks/imported_bookmark_entry.h"
+#include "chrome/browser/favicon/imported_favicon_usage.h"
#include "chrome/browser/importer/ie_importer.h"
#include "chrome/browser/importer/ie_importer_test_registry_overrider_win.h"
#include "chrome/browser/importer/importer_bridge.h"
@@ -307,7 +308,7 @@ class TestObserver : public ProfileWriter,
EXPECT_EQ(history::SOURCE_IE_IMPORTED, visit_source);
}
- virtual void AddBookmarks(const std::vector<BookmarkEntry>& bookmarks,
+ virtual void AddBookmarks(const std::vector<ImportedBookmarkEntry>& bookmarks,
const string16& top_level_folder_name) OVERRIDE {
ASSERT_LE(bookmark_count_ + bookmarks.size(), arraysize(kIEBookmarks));
// Importer should import the IE Favorites folder the same as the list,
@@ -329,7 +330,7 @@ class TestObserver : public ProfileWriter,
}
virtual void AddFavicons(
- const std::vector<history::ImportedFaviconUsage>& usage) OVERRIDE {
+ const std::vector<ImportedFaviconUsage>& usage) OVERRIDE {
// Importer should group the favicon information for each favicon URL.
for (size_t i = 0; i < arraysize(kIEFaviconGroup); ++i) {
GURL favicon_url(kIEFaviconGroup[i].favicon_url);
@@ -387,7 +388,7 @@ class MalformedFavoritesRegistryTestObserver
history::VisitSource visit_source) {}
virtual void AddKeyword(std::vector<TemplateURL*> template_url,
int default_keyword_index) {}
- virtual void AddBookmarks(const std::vector<BookmarkEntry>& bookmarks,
+ virtual void AddBookmarks(const std::vector<ImportedBookmarkEntry>& bookmarks,
const string16& top_level_folder_name) OVERRIDE {
ASSERT_LE(bookmark_count_ + bookmarks.size(),
arraysize(kIESortedBookmarks));

Powered by Google App Engine
This is Rietveld 408576698