Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1084)

Side by Side Diff: chrome/browser/importer/safari_importer_unittest.mm

Issue 14575004: Extract BookmarksFileImporter from Firefox2Importer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: win fix Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/importer/safari_importer.h" 5 #include "chrome/browser/importer/safari_importer.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/file_util.h" 8 #include "base/file_util.h"
9 #include "base/files/file_path.h" 9 #include "base/files/file_path.h"
10 #include "base/files/scoped_temp_dir.h" 10 #include "base/files/scoped_temp_dir.h"
11 #include "base/path_service.h" 11 #include "base/path_service.h"
12 #include "base/string16.h" 12 #include "base/string16.h"
13 #include "base/string_util.h" 13 #include "base/string_util.h"
14 #include "base/strings/sys_string_conversions.h" 14 #include "base/strings/sys_string_conversions.h"
15 #include "base/utf_string_conversions.h" 15 #include "base/utf_string_conversions.h"
16 #include "chrome/browser/bookmarks/imported_bookmark_entry.h"
16 #include "chrome/browser/history/history_types.h" 17 #include "chrome/browser/history/history_types.h"
17 #include "chrome/browser/importer/importer_bridge.h" 18 #include "chrome/browser/importer/importer_bridge.h"
18 #include "chrome/common/chrome_paths.h" 19 #include "chrome/common/chrome_paths.h"
19 #include "sql/connection.h" 20 #include "sql/connection.h"
20 #include "testing/platform_test.h" 21 #include "testing/platform_test.h"
21 22
22 // In order to test the Safari import functionality effectively, we store a 23 // In order to test the Safari import functionality effectively, we store a
23 // simulated Library directory containing dummy data files in the same 24 // simulated Library directory containing dummy data files in the same
24 // structure as ~/Library in the Chrome test data directory. 25 // structure as ~/Library in the Chrome test data directory.
25 // This function returns the path to that directory. 26 // This function returns the path to that directory.
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 }, 121 },
121 { 122 {
122 false, 123 false,
123 GURL("http://www.webkit.org/blog/"), 124 GURL("http://www.webkit.org/blog/"),
124 string16(), 125 string16(),
125 ASCIIToUTF16("Surfin' Safari - The WebKit Blog") 126 ASCIIToUTF16("Surfin' Safari - The WebKit Blog")
126 }, 127 },
127 }; 128 };
128 129
129 scoped_refptr<SafariImporter> importer(GetSafariImporter()); 130 scoped_refptr<SafariImporter> importer(GetSafariImporter());
130 std::vector<ProfileWriter::BookmarkEntry> bookmarks; 131 std::vector<ImportedBookmarkEntry> bookmarks;
131 importer->ParseBookmarks(ASCIIToUTF16("Toolbar"), &bookmarks); 132 importer->ParseBookmarks(ASCIIToUTF16("Toolbar"), &bookmarks);
132 size_t num_bookmarks = bookmarks.size(); 133 size_t num_bookmarks = bookmarks.size();
133 ASSERT_EQ(ARRAYSIZE_UNSAFE(kImportedBookmarksData), num_bookmarks); 134 ASSERT_EQ(ARRAYSIZE_UNSAFE(kImportedBookmarksData), num_bookmarks);
134 135
135 for (size_t i = 0; i < num_bookmarks; ++i) { 136 for (size_t i = 0; i < num_bookmarks; ++i) {
136 ProfileWriter::BookmarkEntry& entry = bookmarks[i]; 137 ImportedBookmarkEntry& entry = bookmarks[i];
137 EXPECT_EQ(kImportedBookmarksData[i].in_toolbar, entry.in_toolbar); 138 EXPECT_EQ(kImportedBookmarksData[i].in_toolbar, entry.in_toolbar);
138 EXPECT_EQ(kImportedBookmarksData[i].url, entry.url); 139 EXPECT_EQ(kImportedBookmarksData[i].url, entry.url);
139 140
140 std::vector<string16> path; 141 std::vector<string16> path;
141 Tokenize(kImportedBookmarksData[i].path, ASCIIToUTF16("/"), &path); 142 Tokenize(kImportedBookmarksData[i].path, ASCIIToUTF16("/"), &path);
142 ASSERT_EQ(path.size(), entry.path.size()); 143 ASSERT_EQ(path.size(), entry.path.size());
143 for (size_t j = 0; j < path.size(); ++j) { 144 for (size_t j = 0; j < path.size(); ++j) {
144 EXPECT_EQ(path[j], entry.path[j]); 145 EXPECT_EQ(path[j], entry.path[j]);
145 } 146 }
146 147
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 EXPECT_EQ(items & importer::COOKIES, importer::NONE); 191 EXPECT_EQ(items & importer::COOKIES, importer::NONE);
191 EXPECT_EQ(items & importer::PASSWORDS, importer::NONE); 192 EXPECT_EQ(items & importer::PASSWORDS, importer::NONE);
192 EXPECT_EQ(items & importer::SEARCH_ENGINES, importer::NONE); 193 EXPECT_EQ(items & importer::SEARCH_ENGINES, importer::NONE);
193 EXPECT_EQ(items & importer::HOME_PAGE, importer::NONE); 194 EXPECT_EQ(items & importer::HOME_PAGE, importer::NONE);
194 195
195 // Check that we don't import anything from a bogus library directory. 196 // Check that we don't import anything from a bogus library directory.
196 base::ScopedTempDir fake_library_dir; 197 base::ScopedTempDir fake_library_dir;
197 ASSERT_TRUE(fake_library_dir.CreateUniqueTempDir()); 198 ASSERT_TRUE(fake_library_dir.CreateUniqueTempDir());
198 EXPECT_FALSE(SafariImporter::CanImport(fake_library_dir.path(), &items)); 199 EXPECT_FALSE(SafariImporter::CanImport(fake_library_dir.path(), &items));
199 } 200 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698