chrome/browser/bookmarks/imported_bookmark_entry.h - Issue 14575004: Extract BookmarksFileImporter from Firefox2Importer.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/bookmarks/imported_bookmark_entry.h

Issue 14575004: Extract BookmarksFileImporter from Firefox2Importer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: win fix Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/bookmarks/bookmark_html_reader.cc ('K') | « chrome/browser/bookmarks/bookmark_html_writer_unittest.cc ('k') | chrome/browser/bookmarks/imported_bookmark_entry.cc » ('j') | chrome/browser/importer/bookmarks_file_importer.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_BOOKMARKS_IMPORTED_BOOKMARK_ENTRY_H_

	6 #define CHROME_BROWSER_BOOKMARKS_IMPORTED_BOOKMARK_ENTRY_H_

	7

	8 #include <vector>

	9

	10 #include "base/string16.h"

	11 #include "base/time.h"

	12 #include "googleurl/src/gurl.h"

	13

	14 struct ImportedBookmarkEntry {

	15 ImportedBookmarkEntry();

	16 ~ImportedBookmarkEntry();
	gab 2013/05/10 20:37:57 I don't think you need to declare a no-op destruct I don't think you need to declare a no-op destructor here. Also, should this have DISALLOW_COPY_AND_ASSIGN? Avi (use Gerrit) 2013/05/10 21:34:53 ../../chrome/browser/bookmarks/imported_bookmark_e Show quoted text On 2013/05/10 20:37:57, gab wrote: > I don't think you need to declare a no-op destructor here. ../../chrome/browser/bookmarks/imported_bookmark_entry.h:15:1: error: [chromium-style] Complex class/struct needs an explicit out-of-line destructor. Show quoted text > Also, should this have DISALLOW_COPY_AND_ASSIGN? No, this is a small utility struct, and we shove it into vectors and copy it all over the place. I can't disallow copying it without completely rewriting all the code that uses it.
	17 bool operator==(const ImportedBookmarkEntry& other) const;

	18

	19 bool in_toolbar;

	20 bool is_folder;

	21 GURL url;

	22 std::vector<string16> path;

	23 base::string16 title;

	24 base::Time creation_time;

	25 };

	26

	27 #endif // CHROME_BROWSER_BOOKMARKS_IMPORTED_BOOKMARK_ENTRY_H_

OLD	NEW