chrome/browser/bookmarks/DEPS - Issue 14575004: Extract BookmarksFileImporter from Firefox2Importer.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/bookmarks/DEPS

Issue 14575004: Extract BookmarksFileImporter from Firefox2Importer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: extraneous include Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | chrome/browser/bookmarks/bookmark_html_writer_unittest.cc » ('j') | chrome/browser/importer/bookmarks_file_importer.h » ('J')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 # Bookmarks is being made into a component (it will end up at	2 # Bookmarks is being made into a component (it will end up at

3 # //components/bookmarks and not depend on //chrome), so we have these basic	3 # //components/bookmarks and not depend on //chrome), so we have these basic

4 # rules followed by temporary exceptions. Please don't add to the list of	4 # rules followed by temporary exceptions. Please don't add to the list of

5 # exceptions!	5 # exceptions!

6 "-chrome/browser",	6 "-chrome/browser",

7 "+chrome/browser/bookmarks",	7 "+chrome/browser/bookmarks",

8	8

9 # TODO(kaiwang): Bring this list to zero.	9 # TODO(kaiwang): Bring this list to zero.

10 # Do not add to the list of temporarily-allowed dependencies below,	10 # Do not add to the list of temporarily-allowed dependencies below,

(...skipping 16 matching lines...) Expand all Loading...
27 "!chrome/browser/profiles/startup_task_runner_service_factory.h",	27 "!chrome/browser/profiles/startup_task_runner_service_factory.h",

28 # Do not add to the list of temporarily-allowed dependencies above,	28 # Do not add to the list of temporarily-allowed dependencies above,

29 # and please do not introduce more #includes of these files.	29 # and please do not introduce more #includes of these files.

30 ]	30 ]

31	31

32 specific_include_rules = {	32 specific_include_rules = {

33 # TODO(kaiwang): Bring this list to zero.	33 # TODO(kaiwang): Bring this list to zero.

34 # Do not add to the list of temporarily-allowed dependencies below,	34 # Do not add to the list of temporarily-allowed dependencies below,

35 # and please do not introduce more #includes of these files.	35 # and please do not introduce more #includes of these files.

36 '._[a-z]test\.cc': [	36 '._[a-z]test\.cc': [

37 "!chrome/browser/importer/firefox2_importer.h",	37 "!chrome/browser/importer/bookmarks_file_importer.h",

38 ]	38 ]

39 }	39 }

OLD	NEW