Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1457493002: Fix Firefox download mechanism. (Closed)

Created:
5 years, 1 month ago by phoglund_chromium
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix Firefox download mechanism. This pulls the new mozdownload as well as requests (which is required by the new mozdownload), and updates our scripts as necessary. BUG=545862 R=kjellander@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/webrtc/webrtc.DEPS/+/00d2c0ecc72c6d60636f98ff7d168fd866d78fd0

Patch Set 1 #

Total comments: 4

Patch Set 2 : Nit fixes #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M DEPS View 3 chunks +11 lines, -9 lines 0 comments Download
M download_firefox_nightly.py View 1 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
phoglund_chromium
5 years, 1 month ago (2015-11-17 16:35:54 UTC) #2
phoglund_chromium
5 years, 1 month ago (2015-11-17 17:40:54 UTC) #3
kjellander_chromium
lgtm with nits. https://codereview.chromium.org/1457493002/diff/1/download_firefox_nightly.py File download_firefox_nightly.py (right): https://codereview.chromium.org/1457493002/diff/1/download_firefox_nightly.py#newcode23 download_firefox_nightly.py:23: sys.path.append(os.path.join(THIRD_PARTY_DIR, 'requests')) nit: sort alphabetically https://codereview.chromium.org/1457493002/diff/1/download_firefox_nightly.py#newcode27 ...
5 years, 1 month ago (2015-11-18 06:53:50 UTC) #4
phoglund_chromium
https://codereview.chromium.org/1457493002/diff/1/download_firefox_nightly.py File download_firefox_nightly.py (right): https://codereview.chromium.org/1457493002/diff/1/download_firefox_nightly.py#newcode23 download_firefox_nightly.py:23: sys.path.append(os.path.join(THIRD_PARTY_DIR, 'requests')) On 2015/11/18 06:53:50, kjellander (chromium) wrote: > ...
5 years, 1 month ago (2015-11-18 14:03:37 UTC) #5
phoglund_chromium
5 years, 1 month ago (2015-11-18 14:07:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
00d2c0ecc72c6d60636f98ff7d168fd866d78fd0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698