Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 1457483002: [profiler] Move away from UnboundedQueue to LockedQueue for regular events. (Closed)

Created:
5 years, 1 month ago by Michael Lippautz
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@locked-queue
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[profiler] Move away from UnboundedQueue to LockedQueue for regular events. Replaces the UnboundedQueue (SP/SC) with LockedQueue (MP/MC). This is necessary as we can have multiple tasks (on multiple platform threads) reporting code move events. Note that the sampling queue is not affected by this change. BUG=chromium:524425 LOG=N Committed: https://crrev.com/2ed3893b4f6155355e030a1fe57a13d726388053 Cr-Commit-Position: refs/heads/master@{#32086}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -14 lines) Patch
M src/atomic-utils.h View 1 chunk +4 lines, -3 lines 0 comments Download
M src/profiler/cpu-profiler.h View 1 2 chunks +5 lines, -4 lines 0 comments Download
M src/profiler/cpu-profiler.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M src/profiler/cpu-profiler-inl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
Hannes Payer (out of office)
lgtm
5 years, 1 month ago (2015-11-18 13:12:21 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457483002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457483002/60001
5 years, 1 month ago (2015-11-18 13:42:15 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-18 14:10:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457483002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457483002/60001
5 years, 1 month ago (2015-11-18 14:13:31 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 1 month ago (2015-11-18 14:14:38 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 14:14:55 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2ed3893b4f6155355e030a1fe57a13d726388053
Cr-Commit-Position: refs/heads/master@{#32086}

Powered by Google App Engine
This is Rietveld 408576698